D19963: Avoid serializing base64 encoded favicon data twice

2019-04-05 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R856:c3611dc98170: Avoid serializing base64 encoded favicon 
data twice (authored by bruns).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19963?vs=54527=55509

REVISION DETAIL
  https://phabricator.kde.org/D19963

AFFECTED FILES
  extension/extension.js

To: bruns, #plasma, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19963: Avoid serializing base64 encoded favicon data twice

2019-04-05 Thread Stefan Brüns 
bruns added a comment.


  Ping!

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D19963

To: bruns, #plasma, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19963: Avoid serializing base64 encoded favicon data twice

2019-03-29 Thread Stefan Brüns 
bruns added a comment.


  Ping!

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D19963

To: bruns, #plasma, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19963: Avoid serializing base64 encoded favicon data twice

2019-03-21 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The URL is ignored in case the image data is available. Avoid pushing
  it twice via DBus.

TEST PLAN
  1. start dbus-monitor
  2. type some string in krunner
  
  before: dict entries contain both favIconData and favIconUrl, with
  
identical data
  
  after:  only favIconData is part of the dict
  
  Favicons are still shown in the krunner results

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  favicondata

REVISION DETAIL
  https://phabricator.kde.org/D19963

AFFECTED FILES
  extension/extension.js

To: bruns, #plasma, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart