D20222: Plasma-Workspace. The last checkbox in the widget settings

[David Edmundson]

davidedmundson closed this revision.
davidedmundson added a comment.


  
https://commits.kde.org/plasma-workspace/eb6f6c2566622b883ca43138f8adee3c29f1f3fa

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20222

To: pavelmos, broulik, #plasma, davidre, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D20222: Plasma-Workspace. The last checkbox in the widget settings

[David Edmundson]

davidedmundson added a comment.


  If it's just a rebase needed, I'll land it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20222

To: pavelmos, broulik, #plasma, davidre, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D20222: Plasma-Workspace. The last checkbox in the widget settings

[Nathaniel Graham]

ngraham added a comment.


  @pavelmos would you like to continue working on this or should someone else 
take it over?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20222

To: pavelmos, broulik, #plasma, davidre, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D20222: Plasma-Workspace. The last checkbox in the widget settings

[Nathaniel Graham]

ngraham added a comment.


  This doesn't apply to master anymore:
  
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D20222.
Checking patch applets/systemmonitor/common/contents/ui/ConfigGeneral.qml...
error: while searching for:
}
} else {
var idx = cfg_sources.indexOf(model.source);
if (idx !== -1) {
cfg_sources.splice(idx, 1);
}
}
cfg_sourcesChanged();

error: patch failed: 
applets/systemmonitor/common/contents/ui/ConfigGeneral.qml:134
Applying patch applets/systemmonitor/common/contents/ui/ConfigGeneral.qml 
with 1 reject...
Rejected hunk #1.

 Patch Failed! 
Usage Exception: Unable to apply patch!
  
  Can you rebase the patch so we can land it?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20222

To: pavelmos, broulik, #plasma, davidre, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20222: Plasma-Workspace. The last checkbox in the widget settings

[Pavel Mos]

pavelmos added a comment.


  In D20222#466116 , @davidedmundson 
wrote:
  
  > Generally I don't like things being blocked for no discernable reason. It 
makes toggling between two things order dependent.
  >
  > > If the user disables the last checkbox, all other checkboxes will 
automatically get enabled in the settings.
  >
  > Yeah, that's weird behaviour.
  >
  > Lets do this.
  
  
  Thanks!
  I have no commit access.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20222

To: pavelmos, broulik, #plasma, davidre, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20222: Plasma-Workspace. The last checkbox in the widget settings

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Generally I don't like things being blocked for no discernable reason. It 
makes toggling between two things order dependent.
  
  > If the user disables the last checkbox, all other checkboxes will 
automatically get enabled in the settings.
  
  Yeah, that's weird behaviour.
  
  Lets do this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20222

To: pavelmos, broulik, #plasma, davidre, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20222: Plasma-Workspace. The last checkbox in the widget settings

[Nathaniel Graham]

ngraham added a comment.


  Oops, sorry for losing track of this. Is it replaced by something else? If 
you don't think it's needed anymore you can Abandon it from the Add Action... 
menu.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20222

To: pavelmos, broulik, #plasma, davidre, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20222: Plasma-Workspace. The last checkbox in the widget settings

[Pavel Mos]

pavelmos added a comment.


  Please skip this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20222

To: pavelmos, broulik, #plasma, davidre, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20222: Plasma-Workspace. The last checkbox in the widget settings

[Pavel Mos]

pavelmos created this revision.
pavelmos added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
pavelmos requested review of this revision.

REVISION SUMMARY
  Added a ban on disabling the last checkbox in the widget settings.
  There will always be at least one graph.
  
  If the user disables the last checkbox, all other checkboxes will 
automatically get enabled in the settings.
  It may be inconvenient for users to uncheck a large number of checkboxes.
  
  This fix is aimed at improving the usability of Plasma-Workspace widgets.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20222

AFFECTED FILES
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml

To: pavelmos, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart