D20908: RFC: Redesign QML applet configuration windows

[Nathaniel Graham]

ngraham added a comment.


  The companion patches have landed; this can go in now!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf updated this revision to Diff 60584.
filipf added a comment.


  highlight effect: remove unused ID and bettery opacity values

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20908?vs=60583=60584

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf updated this revision to Diff 60583.
filipf added a comment.


  Also implement the upcoming highlight style

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20908?vs=60115=60583

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Marco Martin]

mart added a comment.


  In D20908#485103 , @filipf wrote:
  
  > Preview of a highlight style in line with what's being discussed in T11124 
:
  >
  > F6927189: image.png 
  >
  > From a technical POV is it possible to reuse the widgets/tasks SVG here?
  
  
  just answered in real life.
  short answer is.. better not :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf added a comment.


  Preview of a highlight style in line with what's being discussed in T11124 
:
  
  F6927189: image.png 
  
  From a technical POV is it possible to reuse the widgets/tasks SVG here?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  There we go, much better.
  
  F6917696: Screenshot_20190620_151607.png 

  
  This is so nice. Let's not commit it until @mart's companion patch for Breeze 
has been submitted and accepted.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf updated this revision to Diff 60115.
filipf added a comment.


  fix wrong sidebar width

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20908?vs=60101=60115

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Hmm, something's not right anymore:
  
  F6917589: Screenshot_20190620_143140.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf updated this revision to Diff 60101.
filipf added a comment.


  line 218: width -> implicitWidth

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20908?vs=60100=60101

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf updated this revision to Diff 60100.
filipf added a comment.


  rebase on master

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20908?vs=57680=60100

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Marco Martin]

mart added a comment.


  This is the rough patch which gives a rough implementation of this look into 
qwidget config dialogs
  F6866217: fullsidebar.diff 
  
  The real hack which I consider a no-go (and no idea how to avoid) is this 
piece:
  
  - layout->addWidget(mButtonBox);
  
  +if (mPageWidget && mPageWidget->layout()) {
  +mButtonBox->setParent(mPageWidget);
  +
static_cast(mPageWidget->layout())->addWidget(mButtonBox, 4, 1);
  +} else {
  +layout->addWidget(mButtonBox);
  +}
  
  it reparents the buttonbox inside the pagewidget itself to have the buttons 
laid out considering the sidebar.
  This will break badly and possibily crash in many situations, so ideas for 
alternative implementations welcome :D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, ericadams, jraleigh, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf updated this revision to Diff 57680.
filipf added a comment.


  Kirigami.Theme.viewBackgroundColor is deprecated so set the colorSet to 
Theme.View instead

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20908?vs=57255=57680

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Nathaniel Graham]

ngraham added a comment.


  In D20908#461487 , @mart wrote:
  
  > from the screenshots, i like it a lot,the code seems clean enough.
  >
  > However, to continue with that i think some attempt should be done to make 
qwidget based apps follow this as well. (I think we should go on a campaign to 
remove unnecessary frames here too)
  
  
  I absolutely agree 100% on both points.
  
  > with qwidget is perhaps slightly harder to do, but should be totally 
possible
  >  F6811626: Screenshot_20190506_123026.png 

  
  Boom, awesome! How hard would it be to clean up the code to make that 
submittable?
  
  > another issue is that (as kirigami apps) this may look a bit bad with the 
window borders which unfortunately are still default on
  
  That's in progress right now. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Andres Betts]

abetts added a comment.


  Love it!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Marco Martin]

mart added a comment.


  that's a veeery quick and dirty attempt: (so hacky that there is not really 
usable code i'm afraid)
  F6811626: Screenshot_20190506_123026.png 

  
  apart the lack of right margin, that should be easily fixable, the worst 
parts seem to be the repositioning of bottom buttons, putting the help button 
where it is in the screenshot was really an ugly and unreliable hack.
  also that remaining 2 pixels margins around the sidebar doesn't seem to be 
easily killable
  
  if somebody wants to do more research, is very welcome

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Marco Martin]

mart added a comment.


  In D20908#458426 , @broulik wrote:
  
  > I was wondering, wouldn't it also make sense to change the layout to be 
Icon left of text to make it even more consistent with System Settings? Or will 
that eat too much horizontal space?
  
  
  I think a config window is different enough to a dedicated config app to 
justify the difference and there is better to optimize the size

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Marco Martin]

mart added a comment.


  from the screenshots, i like it a lot,the code seems clean enough.
  
  However, to continue with that i think some attempt should be done to make 
qwidget based apps follow this as well. (I think we should go on a campaign to 
remove unnecessary frames here too)
  
  with qwidget is perhaps slightly harder to do, but should be totally possible
  F6811509: Screenshot_20190506_110307.png 

  
  another issue is that (as kirigami apps) this may look a bit bad with the 
window borders which unfortunately are still default on

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham, abetts
Cc: mart, broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D20908: RFC: Redesign QML applet configuration windows

[Nathaniel Graham]

ngraham added a comment.


  I'm so in love with this new style. it's just astonishingly good-looking.
  
  F6801451: Screenshot_20190430_065515.png 

  
  Once this is in users' hands (in conjunction with no borders by default for 
Breeze), I predict that we get a flood of praise for it.
  
  Implementation-wise I wonder if this is the correct place to locate the 
horizontal line below the titlebar. In this case it works, but we have other 
windows that currently need it too (e.g. System Settings, Discover, probably 
any Kirigami app). I wonder if it should be drawn by a framework instead, or 
the Breeze style, or even KWin. Or some combination of the two.
  
  For more on the subject of horizontal lines under titlebars, see the 
discussion in T10201#183425 .

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham
Cc: broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf added a comment.


  Fixed. Not sure if the top separator should stay, but I guess it makes more 
sense if it does:
  
  F6801409: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham
Cc: broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf updated this revision to Diff 57255.
filipf added a comment.


  Don't draw sidebar and its separator when there is only 1 category, also add 
left margin

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20908?vs=57227=57255

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: filipf, #vdg, #plasma, ngraham
Cc: broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Nathaniel Graham]

ngraham added a comment.


  Yeah I think keeping the icons on top is nice here since it makes for large 
click areas. Putting the icon beside the text makes more sense when the number 
of categories is very large, which isn't normally the case for settings windows.
  
  In D20908#458428 , @filipf wrote:
  
  > BTW implementation wise here's one reason why what I did here is not a good 
solution:
  >
  > F6801185: image.png 
  
  
  Looks like the rectangle needs to not be visible when there's only one 
category. Maybe we can get that information from `globalConfigModel`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham
Cc: broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf added a comment.


  In D20908#458426 , @broulik wrote:
  
  > I was wondering, wouldn't it also make sense to change the layout to be 
Icon left of text to make it even more consistent with System Settings? Or will 
that eat too much horizontal space?
  
  
  That would be even more consistent, although we should probably take into 
account the differences between the two cases ie. the number of categories.
  
  When it comes to applet configuration, the most categories I've ever run into 
was 10 in Event Calendar, and you can still fit all of them vertically on a 
1080p screen easily.
  
  But lot of applets only have 2 categories. So yeah if we do row layouts we'd 
be using more horizontal space, however we've got a lot of vertical space so 
there's no need to make that trade-off IMO.
  
  _
  
  BTW implementation wise here's one reason why what I did here is not a good 
solution:
  
  F6801185: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham
Cc: broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Kai Uwe Broulik]

broulik added a comment.


  I was wondering, wouldn't it also make sense to change the layout to be Icon 
left of text to make it even more consistent with System Settings? Or will that 
eat too much horizontal space?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham
Cc: broulik, GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Björn Feber]

GB_2 added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham
Cc: GB_2, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Eike Hein]

hein added a comment.


  Looks great to me. Subtle visual refreshs like this are very appreciated, 
especially when they improve consistency, too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham
Cc: hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Nathaniel Graham]

ngraham added a comment.


  Beautiful.
  
  Now we just need to do it in Breeze too, and turn off those borders when 
using Breeze window decorations.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf updated this revision to Diff 57227.
filipf added a comment.


  have top separator fill the window's width

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20908?vs=57218=57227

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: filipf, #vdg, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Nathaniel Graham]

ngraham added a comment.


  In D20908#458307 , @filipf wrote:
  
  > I agree, the sidebar looks a bit lost there. So do you mean to turn on the 
separator in KWin or add it ourselves like this?
  >
  > F6800729: image.png 
  
  
  C'est magnifique.
  
  In this case my recommendation would be for KWin to do it (it already can via 
that off-by-default feature), we just need to adjust the color so people don't 
hate it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf added a comment.


  I agree, the sidebar looks a bit lost there. So do you mean to turn on the 
separator in KWin or add it ourselves like this?
  
  F6800729: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Nathaniel Graham]

ngraham added a comment.


  In general, this is a change I hugely support. This look for sidebars is 
already used in System Settings, Discover, and other QML-ish apps. It's 
attractive and clean, and provides adequate separation between dissimilar 
elements.
  
  Looking at your Breeze Light and Breeze Dark screenshots makes me think that 
we really need to either make their titlebars have a subtly different color 
from the window, or else draw a line underneath the titlebars. The fact that 
the list just ends is really odd-looking. We already see the effect with System 
Settings: F6489899: Screenshot_20181219_093722.png 

  
  (Than again that's all a task for T10201 
).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20908

To: filipf, #vdg, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf updated this revision to Diff 57218.
filipf added a comment.


  remove unrelated changes

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20908?vs=57217=57218

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20908: RFC: Redesign QML applet configuration windows

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This is patch is a sketch meant to open up discussion about redesigning our 
configuration windows.
  
  We currently have insconsistent padding between Breeze and QML, and could 
improve on the design by providing better visuals, content separation, and 
cohesion with Discover and sidebar view in System Settings.
  
  The patch would also need to be complemented with changes in Breeze.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20908

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart