D21279: [sddm-theme] Add spacing between action buttons' labels

[Filip Fila]

filipf added a comment.


  In D21279#468029 , @davidedmundson 
wrote:
  
  > This is an ugly hack.
  >
  > ActionItems ultimately end up in
  >  SessionManagementScreen.qml:113
  >
  > Row {
  >  id: actionItemsLayout
  >  }
  >
  > A Row has a spacing property.
  
  
  Thanks, I was looking for some sort of a Row(Layout), but as I was expecting 
it to be in ActionButton.qml I couldn't find it. Will push a fix reverting this 
and adding spacing in the SessionManagementScreen.qml.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21279

To: filipf, #vdg, #plasma, ngraham
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21279: [sddm-theme] Add spacing between action buttons' labels

[David Edmundson]

davidedmundson added a comment.


  This is an ugly hack.
  
  ActionItems ultimately end up in
  SessionManagementScreen.qml:113
  
  Row {
  id: actionItemsLayout
  }
  
  A Row has a spacing property.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21279

To: filipf, #vdg, #plasma, ngraham
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21279: [sddm-theme] Add spacing between action buttons' labels

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c92a33c20c53: [sddm-theme] Add spacing between action 
buttons labels (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21279?vs=58269=58423

REVISION DETAIL
  https://phabricator.kde.org/D21279

AFFECTED FILES
  sddm-theme/Main.qml

To: filipf, #vdg, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21279: [sddm-theme] Add spacing between action buttons' labels

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Stable branch please!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  add-spacing-action-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21279

To: filipf, #vdg, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21279: [sddm-theme] Add spacing between action buttons' labels

[Filip Fila]

filipf updated this revision to Diff 58269.
filipf added a comment.


  height=width

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21279?vs=58267=58269

BRANCH
  add-spacing-action-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21279

AFFECTED FILES
  sddm-theme/Main.qml

To: filipf, #vdg, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21279: [sddm-theme] Add spacing between action buttons' labels

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Currently there is no spacing between the labels of action buttons, leading 
to crammed text with longer translations which are not split up into more rows.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  add-spacing-action-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21279

AFFECTED FILES
  sddm-theme/Main.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart