D21408: RFC: [Notifications] Better notification number alignment

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:8f1daa56f9e8: Better notification number alignment 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21408?vs=58711&id=59050#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21408?vs=58711&id=59050

REVISION DETAIL
  https://phabricator.kde.org/D21408

AFFECTED FILES
  applets/notifications/package/contents/ui/CompactRepresentation.qml
  applets/notifications/package/contents/ui/TightLabel.qml

To: broulik, #plasma, #vdg, ngraham
Cc: lavender, cfeck, davidedmundson, ngraham, ndavis, plasma-devel, ericadams, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Since it doesn't regress anything, then I say yeah.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg, ngraham
Cc: lavender, cfeck, davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Kai Uwe Broulik]

broulik added a comment.


  Should we go with this now to improve the situation a little bit at least?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: lavender, cfeck, davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Peridot Lavender]

lavender added a comment.


  In D21408#470219 , @broulik wrote:
  
  > In D21408#470122 , @ngraham 
wrote:
  >
  > > When there are 2 or digits, maybe the circle can expand to become 
pill-shaped
  >
  >
  > The circle comes from Plasma theme, cannot transform it.
  
  
  That might be the best solution though: allowing the theme to transform it 
based on a certain property (in this case number of digits and width)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: lavender, cfeck, davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Noah Davis]

ndavis added a comment.


  Eh, changing the background to solid didn't help (I did include the changes 
from this patch) and it looks somewhat out of place next to the other icons. 
F6859137: Screenshot_20190529_194111.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: cfeck, davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Noah Davis]

ndavis added a comment.


  In D21408#471892 , @ngraham wrote:
  
  > Could we increase the size of the circle in the Plasma theme to make any 
slight mis-alignment less noticeable?
  
  
  It might look out of place next to all the other icons which are always 12px 
high at most. However, I think the misalignment might be less obvious if we 
filled in the circle and used the Background color for the numbers.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: cfeck, davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Nathaniel Graham]

ngraham added a comment.


  Could we increase the size of the circle in the Plasma theme to make any 
slight mis-alignment less noticeable?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: cfeck, davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Kai Uwe Broulik]

broulik added a comment.


  Also, the circle comes from the Plasma theme.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: cfeck, davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Noah Davis]

ndavis added a comment.


  In D21408#470827 , @cfeck wrote:
  
  > Just an idea: run "kcharselect", type "circled digit" resp. "circled 
number". For values <= 20, unicode has pre-rendered glyphs.
  
  
  Unfortunately, there is a jump in size from 10 to 11:
  F6855537: Screenshot_20190527_221327.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: cfeck, davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Christoph Feck]

cfeck added a comment.


  Just an idea: run "kcharselect", type "circled digit" resp. "circled number". 
For values <= 20, unicode has pre-rendered glyphs.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: cfeck, davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Noah Davis]

ndavis added a comment.


  In D21408#470480 , @broulik wrote:
  
  > - Use `QtRendering` as I originally intended
  >
  >   Does this make it any better?
  
  
  The numbers seem to be slightly smaller and fit in the circle slightly 
better, but they're still off to the left a bit, just as much as in the video I 
posted above.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Kai Uwe Broulik]

broulik updated this revision to Diff 58711.
broulik added a comment.


  - Use `QtRendering` as I originally intended
  
  Does this make it any better?

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21408?vs=58658&id=58711

REVISION DETAIL
  https://phabricator.kde.org/D21408

AFFECTED FILES
  applets/notifications/package/contents/ui/CompactRepresentation.qml

To: broulik, #plasma, #vdg
Cc: davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in CompactRepresentation.qml:116
> This doesn't match your description

Ha, no wonder nothing changed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> CompactRepresentation.qml:116
> +text: compactRoot.unreadCount || ""
> +renderType: Text.NativeRendering
>  }

This doesn't match your description

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: davidedmundson, ngraham, ndavis, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Noah Davis]

ndavis added a comment.


  The patch makes the position of the numbers more consistent, but it's 
consistently slightly to the left of center.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: ngraham, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Kai Uwe Broulik]

broulik added a comment.


  In D21408#470122 , @ngraham wrote:
  
  > When there are 2 or digits, maybe the circle can expand to become 
pill-shaped
  
  
  The circle comes from Plasma theme, cannot transform it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: ngraham, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Nathaniel Graham]

ngraham added a comment.


  In D21408#469997 , @broulik wrote:
  
  > F6849423: Screenshot_20190525_182118.png 
 Still looks awful at times :(
  
  
  When there are 2 or digits, maybe the circle can expand to become pill-shaped 
so it can accommodate the increased width? Or maybe the font size should 
decrease?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: ngraham, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Noah Davis]

ndavis added a comment.


  Here is a video showing unread notification numbers up to 21 with this patch. 
The font settings that affect the unread notification number (general) are at 
the default settings.
  
  https://www.youtube.com/watch?v=Npw2XY2x8tI

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Kai Uwe Broulik]

broulik added a comment.


  F6849423: Screenshot_20190525_182118.png 
 Still looks awful at times :(

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

To: broulik, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21408: RFC: [Notifications] Better notification number alignment

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This tries to use `fontSizeMode` but in conjunction with `QtRendering` to 
achieve better number alignment.
  Since this is more "part of an icon" than "proper text" using `QtRendering` 
is acceptable.

TEST PLAN
  Looks fine here but please everyone test since depending on font, size, 
whatever the results vary wildly.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21408

AFFECTED FILES
  applets/notifications/package/contents/ui/CompactRepresentation.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart