D21527: Fix the 'Report bug' button being always disabled

2019-06-02 Thread Daniel Vrátil
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:dd95de337e30: Fix the Report bug button being 
always disabled (authored by dvratil).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21527?vs=58992=59019

REVISION DETAIL
  https://phabricator.kde.org/D21527

AFFECTED FILES
  src/config-drkonqi.h.cmake
  src/drkonqidialog.cpp

To: dvratil, dfaure, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D21527: Fix the 'Report bug' button being always disabled

2019-06-01 Thread Daniel Vrátil
dvratil created this revision.
dvratil added a reviewer: dfaure.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dvratil requested review of this revision.

REVISION SUMMARY
  The commit d4ae04a7 
 has 
changed #define of HAVE_XMLRPCLCIENT
  to #cmakedefine01 - since HAVE_XMLRPCCLIENT is not defined anywhere
  in the CMakeFiles.txt, this lead to the 'Report bug' button being
  unconditionally disabled at compile time.
  
  Since KXmlRpcClient is a REQUIRED dependency (and has been for a while),
  we can just remove the macro altogether.
  
  BUG: 406606
  FIXED-IN: 5.16.0
  CCMAIL: fa...@kde.org

TEST PLAN
  The 'Report bug' button is enabled

REPOSITORY
  R871 DrKonqi

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21527

AFFECTED FILES
  src/config-drkonqi.h.cmake
  src/drkonqidialog.cpp

To: dvratil, dfaure
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart