D22000: [colors/Breeze] Change selected text color to black

[Noah Davis]

ndavis abandoned this revision.
ndavis added a comment.


  Abandoning because it can negatively affect other widget styles.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22000

To: ndavis, #vdg, #breeze, #plasma, ngraham
Cc: filipf, IlyaBizyaev, ngraham, cfeck, zzag, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22000: [colors/Breeze] Change selected text color to black

[Noah Davis]

ndavis added a comment.


  In D22000#484409 , @IlyaBizyaev 
wrote:
  
  > Looks fine in the menu, but black on bright blue in the list model below is 
just wrong now.
  
  
  I don't actually have all the necessary patches right now, so pretend you 
don't see that.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22000

To: ndavis, #vdg, #breeze, #plasma, ngraham
Cc: filipf, IlyaBizyaev, ngraham, cfeck, zzag, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22000: [colors/Breeze] Change selected text color to black

[Filip Fila]

filipf added a comment.


  In D22000#484409 , @IlyaBizyaev 
wrote:
  
  > Looks fine in the menu, but black on bright blue in the list model below is 
just wrong now.
  
  
  There would be no black on bright blue once the task is finished; that's one 
of the points - to not have white on bright blue.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22000

To: ndavis, #vdg, #breeze, #plasma, ngraham
Cc: filipf, IlyaBizyaev, ngraham, cfeck, zzag, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22000: [colors/Breeze] Change selected text color to black

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  Looks fine in the menu, but black on bright blue in the list model below is 
just wrong now.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22000

To: ndavis, #vdg, #breeze, #plasma, ngraham
Cc: IlyaBizyaev, ngraham, cfeck, zzag, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22000: [colors/Breeze] Change selected text color to black

[Nathaniel Graham]

ngraham added subscribers: cfeck, ngraham.
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This also needs to be changed in the Default theme here in the same repo, in 
the Kirigami repo (which has a duplicate of it) and in some Framework that I 
never remember (maybe @cfeck remembers).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22000

To: ndavis, #vdg, #breeze, #plasma, ngraham
Cc: ngraham, cfeck, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22000: [colors/Breeze] Change selected text color to black

[Vlad Zagorodniy]

zzag added a comment.


  Can you attach before & after screenshots?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22000

To: ndavis, #vdg, #breeze, #plasma
Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart