D22179: [mobile/wifi] Move network en/disable into main action

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:3923c45e4c7b: [mobile/wifi] Move network en/disable into 
main action (authored by nicolasfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22179?vs=60893=60907

REVISION DETAIL
  https://phabricator.kde.org/D22179

AFFECTED FILES
  mobile/wifi/package/contents/ui/NetworkListView.qml

To: nicolasfella, #vdg, #plasma, jgrulich, mkacej
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22179: [mobile/wifi] Move network en/disable into main action

[Nathaniel Graham]

ngraham added a comment.


  I kind of feel like on mobile, the toolbar itself should just move to the 
bottom. No need to use a whole new paradigm of floating text-less buttons that 
obscure the content and don't have labels. I know this is basically copied from 
Android, but I don't really like it there either. It just seems like an 
over-complicated and over-designed solution to a simple problem.
  
  Anyway, I'll shut up now, and we should have that discussion somewhere else, 
not in the comments section of your patch here. :)

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22179

To: nicolasfella, #vdg, #plasma, jgrulich, mkacej
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22179: [mobile/wifi] Move network en/disable into main action

[Nicolas Fella]

nicolasfella added a comment.


  In D22179#488748 , @ngraham wrote:
  
  > +1 for porting to use the correct Kirigami paradigm.
  >
  > I feel like trying to do this exposes problems with our general general 
style (toggle-able toolbar button don't have a special appearance to indicate 
this) as well as the "floating text-less button" paradigm for mobile (same 
problem, plus the lack of text makes it even harder to tell what it's going to 
do for semi-complex actions). I won't block it, but the matter might require 
more discussion.
  
  
  I agree. I'm not particularly happy with the current solution

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22179

To: nicolasfella, #vdg, #plasma, jgrulich, mkacej
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22179: [mobile/wifi] Move network en/disable into main action

[Nathaniel Graham]

ngraham added a comment.


  +1 for porting to use the correct Kirigami paradigm.
  
  I feel like trying to do this exposes problems with our general general style 
(toggle-able toolbar button don't have a special appearance to indicate this) 
as well as the "floating text-less button" paradigm for mobile (same problem, 
plus the lack of text makes it even harder to tell what it's going to do for 
semi-complex actions). I won't block it, but the matter might require more 
discussion.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22179

To: nicolasfella, #vdg, #plasma, jgrulich, mkacej
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22179: [mobile/wifi] Move network en/disable into main action

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The current switch at the top is both not very visually appealing and 
violates the Kirigami principle of putting relevant controls on the bottom 
where they are easily reachable

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  networklist

REVISION DETAIL
  https://phabricator.kde.org/D22179

AFFECTED FILES
  mobile/wifi/package/contents/ui/NetworkListView.qml

To: nicolasfella, #vdg, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart