D22289: hijack nextbutton on preview page and rename it to Submit!

2019-07-05 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:470549de27d8: hijack nextbutton on preview page and 
rename it to Submit! (authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22289?vs=61205&id=61223#toc

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22289?vs=61205&id=61223

REVISION DETAIL
  https://phabricator.kde.org/D22289

AFFECTED FILES
  src/bugzillaintegration/reportassistantdialog.cpp
  src/bugzillaintegration/reportassistantdialog.h
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.h

To: sitter, #plasma, #vdg, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22289: hijack nextbutton on preview page and rename it to Submit!

2019-07-05 Thread Harald Sitter
sitter created this revision.
sitter added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  it's very awkward when you don't know when a change happens or
  not, so suitably label the next button so it actually says submit when
  it will trigger the report submission.
  
  CHANGELOG: Buttons are more suitably labled when bug reports are submitted

TEST PLAN
  file bug report -> preview page has submit button -> going back it is not 
submit -> clicking submit it also turns back to next (albeit disabled)

REPOSITORY
  R871 DrKonqi

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D22289

AFFECTED FILES
  src/bugzillaintegration/reportassistantdialog.cpp
  src/bugzillaintegration/reportassistantdialog.h
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.h

To: sitter, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22289: hijack nextbutton on preview page and rename it to Submit!

2019-07-05 Thread Harald Sitter
sitter added a comment.


  Looks comme ca:
  F6973746: Screenshot_20190705_125955.png 


REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22289

To: sitter, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart