D22485: wrap the details example label+spacer in a container widget

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:5a59721d7efe: wrap the details example label+spacer in a 
container widget (authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22485?vs=62038=62158

REVISION DETAIL
  https://phabricator.kde.org/D22485

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_base.cpp
  src/bugzillaintegration/ui/assistantpage_bugawareness.ui

To: sitter, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22485: wrap the details example label+spacer in a container widget

[Harald Sitter]

sitter added a comment.


  bug had one. but true enough
  
  FTR:
  
  without this diff
  F7062349: Screenshot_20190721_002927.png 

  
  with this diff
  F7062351: Screenshot_20190721_003021.png 


REPOSITORY
  R871 DrKonqi

BRANCH
  spacer

REVISION DETAIL
  https://phabricator.kde.org/D22485

To: sitter, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22485: wrap the details example label+spacer in a container widget

[Aleix Pol Gonzalez]

apol added a comment.


  When doing this kind of changes it would be useful to have a screenshot by it.

REPOSITORY
  R871 DrKonqi

BRANCH
  spacer

REVISION DETAIL
  https://phabricator.kde.org/D22485

To: sitter, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22485: wrap the details example label+spacer in a container widget

[Harald Sitter]

sitter updated this revision to Diff 62037.
sitter added a comment.


  reduce noise I think

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22485?vs=61845=62037

BRANCH
  spacer

REVISION DETAIL
  https://phabricator.kde.org/D22485

AFFECTED FILES
  CMakeLists.txt
  drkonqi.categories
  src/CMakeLists.txt
  src/aboutbugreportingdialog.cpp
  src/backtraceratingwidget.cpp
  src/backtraceratingwidget.h
  src/backtracewidget.cpp
  src/backtracewidget.h
  src/bugzillaintegration/assistantpage_bugzilla_version.cpp
  src/bugzillaintegration/assistantpage_bugzilla_version.h
  src/bugzillaintegration/bugzillalib.cpp
  src/bugzillaintegration/bugzillalib.h
  src/bugzillaintegration/duplicatefinderjob.cpp
  src/bugzillaintegration/duplicatefinderjob.h
  src/bugzillaintegration/libbugzilla/CMakeLists.txt
  src/bugzillaintegration/libbugzilla/apijob.cpp
  src/bugzillaintegration/libbugzilla/apijob.h
  src/bugzillaintegration/libbugzilla/autotests/CMakeLists.txt
  src/bugzillaintegration/libbugzilla/autotests/attachmenttest.cpp
  src/bugzillaintegration/libbugzilla/autotests/bugtest.cpp
  src/bugzillaintegration/libbugzilla/autotests/bugzillatest.cpp
  src/bugzillaintegration/libbugzilla/autotests/commenttest.cpp
  src/bugzillaintegration/libbugzilla/autotests/connectiontest.cpp
  src/bugzillaintegration/libbugzilla/autotests/data/attachment.new.json
  src/bugzillaintegration/libbugzilla/autotests/data/bugs.dragonplayer.json
  src/bugzillaintegration/libbugzilla/autotests/data/bugs.new.json
  src/bugzillaintegration/libbugzilla/autotests/data/bugs.unresolved.json
  src/bugzillaintegration/libbugzilla/autotests/data/bugs.update.json
  src/bugzillaintegration/libbugzilla/autotests/data/bugzilla.login.json
  src/bugzillaintegration/libbugzilla/autotests/data/bugzilla.version.json
  src/bugzillaintegration/libbugzilla/autotests/data/comments.json
  src/bugzillaintegration/libbugzilla/autotests/data/error.http
  src/bugzillaintegration/libbugzilla/autotests/data/error.nobug.invalid.json
  src/bugzillaintegration/libbugzilla/autotests/data/hi.http
  src/bugzillaintegration/libbugzilla/autotests/data/product.dragonplayer.json
  src/bugzillaintegration/libbugzilla/autotests/data/put.http
  src/bugzillaintegration/libbugzilla/autotests/producttest.cpp
  src/bugzillaintegration/libbugzilla/bugzilla.cpp
  src/bugzillaintegration/libbugzilla/bugzilla.h
  src/bugzillaintegration/libbugzilla/clients/attachmentclient.cpp
  src/bugzillaintegration/libbugzilla/clients/attachmentclient.h
  src/bugzillaintegration/libbugzilla/clients/bugclient.cpp
  src/bugzillaintegration/libbugzilla/clients/bugclient.h
  src/bugzillaintegration/libbugzilla/clients/clientbase.cpp
  src/bugzillaintegration/libbugzilla/clients/clientbase.h
  src/bugzillaintegration/libbugzilla/clients/commands/bugsearch.cpp
  src/bugzillaintegration/libbugzilla/clients/commands/bugsearch.h
  src/bugzillaintegration/libbugzilla/clients/commands/bugupdate.cpp
  src/bugzillaintegration/libbugzilla/clients/commands/bugupdate.h
  src/bugzillaintegration/libbugzilla/clients/commands/commandbase.h
  src/bugzillaintegration/libbugzilla/clients/commands/jsoncommand.cpp
  src/bugzillaintegration/libbugzilla/clients/commands/jsoncommand.h
  src/bugzillaintegration/libbugzilla/clients/commands/newattachment.cpp
  src/bugzillaintegration/libbugzilla/clients/commands/newattachment.h
  src/bugzillaintegration/libbugzilla/clients/commands/newbug.cpp
  src/bugzillaintegration/libbugzilla/clients/commands/newbug.h
  src/bugzillaintegration/libbugzilla/clients/commands/querycommand.cpp
  src/bugzillaintegration/libbugzilla/clients/commands/querycommand.h
  src/bugzillaintegration/libbugzilla/clients/commentclient.cpp
  src/bugzillaintegration/libbugzilla/clients/commentclient.h
  src/bugzillaintegration/libbugzilla/clients/productclient.cpp
  src/bugzillaintegration/libbugzilla/clients/productclient.h
  src/bugzillaintegration/libbugzilla/connection.cpp
  src/bugzillaintegration/libbugzilla/connection.h
  src/bugzillaintegration/libbugzilla/exceptions.cpp
  src/bugzillaintegration/libbugzilla/exceptions.h
  src/bugzillaintegration/libbugzilla/models/bug.cpp
  src/bugzillaintegration/libbugzilla/models/bug.h
  src/bugzillaintegration/libbugzilla/models/comment.cpp
  src/bugzillaintegration/libbugzilla/models/comment.h
  src/bugzillaintegration/libbugzilla/models/logindetails.cpp
  src/bugzillaintegration/libbugzilla/models/logindetails.h
  src/bugzillaintegration/libbugzilla/models/product.cpp
  src/bugzillaintegration/libbugzilla/models/product.h
  src/bugzillaintegration/parsebugbacktraces.cpp
  src/bugzillaintegration/parsebugbacktraces.h
  src/bugzillaintegration/productmapping.cpp
  src/bugzillaintegration/productmapping.h
  src/bugzillaintegration/reportassistantdialog.cpp
  src/bugzillaintegration/reportassistantdialog.h
  src/bugzillaintegration/reportassistantpages_base.cpp
  src/bugzillaintegration/reportassistantpages_base.h
  

D22485: wrap the details example label+spacer in a container widget

[Harald Sitter]

sitter updated this revision to Diff 62038.
sitter added a comment.


  reduce noise no2

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22485?vs=62037=62038

BRANCH
  spacer

REVISION DETAIL
  https://phabricator.kde.org/D22485

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_base.cpp
  src/bugzillaintegration/ui/assistantpage_bugawareness.ui

To: sitter, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22485: wrap the details example label+spacer in a container widget

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this way we can control both their visibility in a single call. with the
  previous code we'd only set the label as hidden and leave a dangling
  spacer to mess with the layout.
  
  BUG: 409807

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22485

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_base.cpp
  src/bugzillaintegration/ui/assistantpage_bugawareness.ui

To: sitter
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart