D22494: Attempt to support different collections of Unsplash

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:fe8c40dc3b9a: Attempt to support different collections of 
Unsplash (authored by Guo Yunhe i...@guoyunhe.me).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=62638=62657

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma, ngraham
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe added inline comments.

INLINE COMMENTS

> ngraham wrote in potdprovider.cpp:54
> The lack of error handling and else blocks for all the ifs in this new code 
> makes me feel a bit nervous.

Read Qt documentation that `QVariant::toString()` will always return a string 
even if the type is not supported (empty string). So this code won't produce 
any error/exception.

> ngraham wrote in config.qml:208
> Since this is only used once, you don't need to make it a function; just put 
> all of this stuff in the `Component.onCompleted:` directly

Fixed.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 62638.
guoyunhe marked an inline comment as done.
guoyunhe added a comment.


  - Unsplash category combobox

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=62636=62638

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 62636.
guoyunhe added a comment.


  - Unsplash category combobox

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=62551=62636

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe added inline comments.

INLINE COMMENTS

> ngraham wrote in potdprovider.cpp:54
> The lack of error handling and else blocks for all the ifs in this new code 
> makes me feel a bit nervous.

`date` is optional, so if it not found, just leave it as undefined. I can add 
some detection to `toString()` function, in case they passed some non-string 
args. `mach()` should be safe.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> potdprovider.cpp:54
> +}
> +}
>  }

The lack of error handling and else blocks for all the ifs in this new code 
makes me feel a bit nervous.

> config.qml:208
> +
> +function setCategory() {
> +for (var i = 0; i < model.length; i++) {

Since this is only used once, you don't need to make it a function; just put 
all of this stuff in the `Component.onCompleted:` directly

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Nathaniel Graham]

ngraham added a comment.


  All right, that's just fine!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe added a comment.


  In D22494#502354 , @ngraham wrote:
  
  > One UI improvement I could see is to allow multi-selection of categories, 
so for example you could see images from all the nature-related categories but 
not Car or Sports.
  >
  > The way I'd envision this working is that instead of a combo box, a label 
would display the currently selected categories. Next to it would be a button 
labeled "Change categories" that would use the multi-page KCM API to take the 
user to another page with a checkbox for each category. This page would allow 
selecting any assortment of categories, which would then be listed on the main 
page. It would be sort of like the corner selector UI in the new Notifications 
KCM.
  
  
  Multi-selection might be difficult to implement in back end. The Unsplash 
Source API I use only supports a single collection ID. Search API might support 
multiple keywords, but it is like "AND" logic, not "OR" logic. So for now, I 
cannot achieve this function.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Nathaniel Graham]

ngraham added a comment.


  Tried it out. My reaction is: "Wow, this is really nice."
  
  One UI improvement I could see is to allow multi-selection of categories, so 
for example you could see images from all the nature-related categories but not 
Car or Sports.
  
  The way I'd envision this working is that instead of a combo box, a label 
would display the currently selected categories. Next to it would be a button 
labeled "Change categories" that would use the multi-page KCM API to take the 
user to another page with a checkbox for each category. This page would allow 
selecting any assortment of categories, which would then be listed on the main 
page. It would be sort of like the corner selector UI in the new Notifications 
KCM.
  
  Anyway, that's definitely a nice-to-have, and this seems fine from a 
functional and UI perspective already.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Nathaniel Graham]

ngraham added a comment.


  Oh sweet! I guess I should actually test it out. :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe added a comment.


  In D22494#502187 , @ngraham wrote:
  
  > Nice!
  >
  > How about adding an "All" entry for the combo box which would show you 
wallpapers from any category? Is that possible?
  
  
  I already added "All" option.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Nathaniel Graham]

ngraham added a comment.


  Nice!
  
  How about adding an "All" entry for the combo box which would show you 
wallpapers from any category? Is that possible?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe added a comment.


  Now it is working again! You will have a Category combobox to choose photo 
collections from Unsplash
  
  F7096418: image.png 

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 62551.
guoyunhe added a comment.


  - Unsplash category combobox

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=62550=62551

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 62550.
guoyunhe added a comment.


  - Unsplash category combobox

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=62549=62550

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 62549.
guoyunhe added a comment.


  - Unsplash category combobox

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=62547=62549

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 62547.
guoyunhe added a comment.


  - Unsplash category combobox

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=62546=62547

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 62546.
guoyunhe added a comment.


  - Unsplash category combobox

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=62541=62546

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 62541.
guoyunhe added a comment.


Fix crashing

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=62539=62541

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe added a comment.


  The new change try to add a new ComboBox "Category" and pass the value to 
PODT data engine. This also introduced a new configuration option. But now it 
makes plasmashell crash without useful error output.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 62539.
guoyunhe added a comment.


  - Unsplash category combobox

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=62538=62539

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 62538.
guoyunhe added a comment.


  - Unsplash category combobox

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=61901=62538

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/potd.cpp
  dataengines/potd/potd.h
  dataengines/potd/potdprovider.cpp
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe added a comment.


  In D22494#499592 , @ngraham wrote:
  
  > In D22494#499587 , @filipf wrote:
  >
  > > Could we only have Unsplash as the provider and the an additional 
combobox that would allow choosing the category?
  >
  >
  > +1, this should be a single Unsplash plugin whose user-facing UI has a 
combobox allowing you to specify the collection.
  
  
  I also feel this is better. We can even provide preview thumbnails before 
users choose a wallpaper collection. The only disadvantage is that I have to 
write a new wallpaper plugin and its UI.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Nathaniel Graham]

ngraham added a comment.


  In D22494#499587 , @filipf wrote:
  
  > Could we only have Unsplash as the provider and the an additional combobox 
that would allow choosing the category?
  
  
  +1, this should be a single Unsplash plugin whose user-facing UI has a 
combobox allowing you to specify the collection.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Filip Fila]

filipf added a comment.


  Could we only have Unsplash as the provider and the an additional combobox 
that would allow choosing the category?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D22494

To: guoyunhe, #plasma
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 61901.
guoyunhe edited the summary of this revision.
guoyunhe added a comment.


  Change default collectionId to all wallpapers instead of desktop wallpaper

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=61899=61901

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/generate_unsplash_provider.sh
  dataengines/potd/unsplashanimalprovider.cpp
  dataengines/potd/unsplashanimalprovider.h
  dataengines/potd/unsplashanimalprovider.json
  dataengines/potd/unsplashbackgroundprovider.cpp
  dataengines/potd/unsplashbackgroundprovider.h
  dataengines/potd/unsplashbackgroundprovider.json
  dataengines/potd/unsplashbaseprovider.cpp
  dataengines/potd/unsplashbaseprovider.h
  dataengines/potd/unsplashbeachprovider.cpp
  dataengines/potd/unsplashbeachprovider.h
  dataengines/potd/unsplashbeachprovider.json
  dataengines/potd/unsplashblackprovider.cpp
  dataengines/potd/unsplashblackprovider.h
  dataengines/potd/unsplashblackprovider.json
  dataengines/potd/unsplashcarprovider.cpp
  dataengines/potd/unsplashcarprovider.h
  dataengines/potd/unsplashcarprovider.json
  dataengines/potd/unsplashchristmasprovider.cpp
  dataengines/potd/unsplashchristmasprovider.h
  dataengines/potd/unsplashchristmasprovider.json
  dataengines/potd/unsplashcoolprovider.cpp
  dataengines/potd/unsplashcoolprovider.h
  dataengines/potd/unsplashcoolprovider.json
  dataengines/potd/unsplashcuteprovider.cpp
  dataengines/potd/unsplashcuteprovider.h
  dataengines/potd/unsplashcuteprovider.json
  dataengines/potd/unsplashdesignprovider.cpp
  dataengines/potd/unsplashdesignprovider.h
  dataengines/potd/unsplashdesignprovider.json
  dataengines/potd/unsplashfallprovider.cpp
  dataengines/potd/unsplashfallprovider.h
  dataengines/potd/unsplashfallprovider.json
  dataengines/potd/unsplashflowerprovider.cpp
  dataengines/potd/unsplashflowerprovider.h
  dataengines/potd/unsplashflowerprovider.json
  dataengines/potd/unsplashfunnyprovider.cpp
  dataengines/potd/unsplashfunnyprovider.h
  dataengines/potd/unsplashfunnyprovider.json
  dataengines/potd/unsplashgalaxyprovider.cpp
  dataengines/potd/unsplashgalaxyprovider.h
  dataengines/potd/unsplashgalaxyprovider.json
  dataengines/potd/unsplashloveprovider.cpp
  dataengines/potd/unsplashloveprovider.h
  dataengines/potd/unsplashloveprovider.json
  dataengines/potd/unsplashmusicprovider.cpp
  dataengines/potd/unsplashmusicprovider.h
  dataengines/potd/unsplashmusicprovider.json
  dataengines/potd/unsplashnatureprovider.cpp
  dataengines/potd/unsplashnatureprovider.h
  dataengines/potd/unsplashnatureprovider.json
  dataengines/potd/unsplashpeopleprovider.cpp
  dataengines/potd/unsplashpeopleprovider.h
  dataengines/potd/unsplashpeopleprovider.json
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  dataengines/potd/unsplashsportsprovider.cpp
  dataengines/potd/unsplashsportsprovider.h
  dataengines/potd/unsplashsportsprovider.json
  dataengines/potd/unsplashsummerprovider.cpp
  dataengines/potd/unsplashsummerprovider.h
  dataengines/potd/unsplashsummerprovider.json
  dataengines/potd/unsplashtravelprovider.cpp
  dataengines/potd/unsplashtravelprovider.h
  dataengines/potd/unsplashtravelprovider.json
  dataengines/potd/unsplashtumblrprovider.cpp
  dataengines/potd/unsplashtumblrprovider.h
  dataengines/potd/unsplashtumblrprovider.json

To: guoyunhe, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 61899.
guoyunhe added a comment.


  Add all Unsplash Wallpaper collections

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=61877=61899

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/generate_unsplash_provider.sh
  dataengines/potd/unsplashanimalprovider.cpp
  dataengines/potd/unsplashanimalprovider.h
  dataengines/potd/unsplashanimalprovider.json
  dataengines/potd/unsplashbackgroundprovider.cpp
  dataengines/potd/unsplashbackgroundprovider.h
  dataengines/potd/unsplashbackgroundprovider.json
  dataengines/potd/unsplashbaseprovider.cpp
  dataengines/potd/unsplashbaseprovider.h
  dataengines/potd/unsplashbeachprovider.cpp
  dataengines/potd/unsplashbeachprovider.h
  dataengines/potd/unsplashbeachprovider.json
  dataengines/potd/unsplashblackprovider.cpp
  dataengines/potd/unsplashblackprovider.h
  dataengines/potd/unsplashblackprovider.json
  dataengines/potd/unsplashcarprovider.cpp
  dataengines/potd/unsplashcarprovider.h
  dataengines/potd/unsplashcarprovider.json
  dataengines/potd/unsplashchristmasprovider.cpp
  dataengines/potd/unsplashchristmasprovider.h
  dataengines/potd/unsplashchristmasprovider.json
  dataengines/potd/unsplashcoolprovider.cpp
  dataengines/potd/unsplashcoolprovider.h
  dataengines/potd/unsplashcoolprovider.json
  dataengines/potd/unsplashcuteprovider.cpp
  dataengines/potd/unsplashcuteprovider.h
  dataengines/potd/unsplashcuteprovider.json
  dataengines/potd/unsplashdesignprovider.cpp
  dataengines/potd/unsplashdesignprovider.h
  dataengines/potd/unsplashdesignprovider.json
  dataengines/potd/unsplashfallprovider.cpp
  dataengines/potd/unsplashfallprovider.h
  dataengines/potd/unsplashfallprovider.json
  dataengines/potd/unsplashflowerprovider.cpp
  dataengines/potd/unsplashflowerprovider.h
  dataengines/potd/unsplashflowerprovider.json
  dataengines/potd/unsplashfunnyprovider.cpp
  dataengines/potd/unsplashfunnyprovider.h
  dataengines/potd/unsplashfunnyprovider.json
  dataengines/potd/unsplashgalaxyprovider.cpp
  dataengines/potd/unsplashgalaxyprovider.h
  dataengines/potd/unsplashgalaxyprovider.json
  dataengines/potd/unsplashloveprovider.cpp
  dataengines/potd/unsplashloveprovider.h
  dataengines/potd/unsplashloveprovider.json
  dataengines/potd/unsplashmusicprovider.cpp
  dataengines/potd/unsplashmusicprovider.h
  dataengines/potd/unsplashmusicprovider.json
  dataengines/potd/unsplashnatureprovider.cpp
  dataengines/potd/unsplashnatureprovider.h
  dataengines/potd/unsplashnatureprovider.json
  dataengines/potd/unsplashpeopleprovider.cpp
  dataengines/potd/unsplashpeopleprovider.h
  dataengines/potd/unsplashpeopleprovider.json
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  dataengines/potd/unsplashsportsprovider.cpp
  dataengines/potd/unsplashsportsprovider.h
  dataengines/potd/unsplashsportsprovider.json
  dataengines/potd/unsplashsummerprovider.cpp
  dataengines/potd/unsplashsummerprovider.h
  dataengines/potd/unsplashsummerprovider.json
  dataengines/potd/unsplashtravelprovider.cpp
  dataengines/potd/unsplashtravelprovider.h
  dataengines/potd/unsplashtravelprovider.json
  dataengines/potd/unsplashtumblrprovider.cpp
  dataengines/potd/unsplashtumblrprovider.h
  dataengines/potd/unsplashtumblrprovider.json

To: guoyunhe, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 61877.
guoyunhe added a comment.


  Better naming

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=61876=61877

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/unsplashbaseprovider.cpp
  dataengines/potd/unsplashbaseprovider.h
  dataengines/potd/unsplashnatureprovider.cpp
  dataengines/potd/unsplashnatureprovider.h
  dataengines/potd/unsplashnatureprovider.json
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h

To: guoyunhe, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 61876.
guoyunhe added a comment.


  Use constructor parameter to pass collection ID

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=61873=61876

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/unsplashallprovider.cpp
  dataengines/potd/unsplashallprovider.h
  dataengines/potd/unsplashallprovider.json
  dataengines/potd/unsplashnatureprovider.cpp
  dataengines/potd/unsplashnatureprovider.h
  dataengines/potd/unsplashnatureprovider.json
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  dataengines/potd/unsplashprovider.json

To: guoyunhe, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 61873.
guoyunhe added a comment.


  Remove KIO linking

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=61872=61873

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/unsplashallprovider.cpp
  dataengines/potd/unsplashallprovider.h
  dataengines/potd/unsplashallprovider.json
  dataengines/potd/unsplashnatureprovider.cpp
  dataengines/potd/unsplashnatureprovider.h
  dataengines/potd/unsplashnatureprovider.json
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  dataengines/potd/unsplashprovider.json

To: guoyunhe, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe updated this revision to Diff 61872.
guoyunhe added a comment.


  Solve linking issue

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22494?vs=61868=61872

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/unsplashallprovider.cpp
  dataengines/potd/unsplashallprovider.h
  dataengines/potd/unsplashallprovider.json
  dataengines/potd/unsplashnatureprovider.cpp
  dataengines/potd/unsplashnatureprovider.h
  dataengines/potd/unsplashnatureprovider.json
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  dataengines/potd/unsplashprovider.json

To: guoyunhe, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22494: Attempt to support different collections of Unsplash

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  Here are some linking issues beyond my knowledge of C++ and CMake. Any 
suggestions?

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22494

AFFECTED FILES
  dataengines/potd/CMakeLists.txt
  dataengines/potd/unsplashallprovider.cpp
  dataengines/potd/unsplashallprovider.h
  dataengines/potd/unsplashallprovider.json
  dataengines/potd/unsplashnatureprovider.cpp
  dataengines/potd/unsplashnatureprovider.h
  dataengines/potd/unsplashnatureprovider.json
  dataengines/potd/unsplashprovider.cpp
  dataengines/potd/unsplashprovider.h
  dataengines/potd/unsplashprovider.json

To: guoyunhe
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart