D22648: make handle follow arbitrary height of the drawer
This revision was automatically updated to reflect the committed changes. Closed by commit R169:518444e4191a: make handle follow arbitrary height of the drawer (authored by camiloh). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22648?vs=62345=62535 REVISION DETAIL https://phabricator.kde.org/D22648 AFFECTED FILES src/controls/templates/OverlayDrawer.qml To: camiloh, mart, #kirigami Cc: camiloh, plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein
D22648: make handle follow arbitrary height of the drawer
camiloh updated this revision to Diff 62345. camiloh added a comment. now using root.parent instead of applicationWindow() REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22648?vs=62309=62345 BRANCH handle-follow-drawer (branched from master) REVISION DETAIL https://phabricator.kde.org/D22648 AFFECTED FILES src/controls/templates/OverlayDrawer.qml To: camiloh, mart, #kirigami Cc: camiloh, plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein
D22648: make handle follow arbitrary height of the drawer
mart added inline comments.
INLINE COMMENTS
> OverlayDrawer.qml:210
> +if(root.height < applicationWindow().height) {
> +margin = applicationWindow().height - root.height -
> root.y + Units.smallSpacing;
> +}
applicationWindow() should be replaceable with root.parent, and that makes it
work also when not in a kirigami applicationwindow
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D22648
To: camiloh, mart, #kirigami
Cc: camiloh, plasma-devel, fbampaloukas, domson, dkardarakos, apol,
davidedmundson, mart, hein
D22648: make handle follow arbitrary height of the drawer
camiloh updated this revision to Diff 62309. camiloh added a comment. take into consideration the y position Summary: if the drawer height prop has been set to a custom value, might as well the y position too, so take it into account to position the handle REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22648?vs=62302=62309 BRANCH handle-follow-drawer (branched from master) REVISION DETAIL https://phabricator.kde.org/D22648 AFFECTED FILES src/controls/templates/OverlayDrawer.qml To: camiloh, mart, #kirigami Cc: camiloh, plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein
D22648: make handle follow arbitrary height of the drawer
camiloh created this revision. camiloh added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. camiloh requested review of this revision. REVISION SUMMARY If the height of the drawer is set to a different value from the applicationWindow height, then the drawer handle follows the bottom on the drawer, staying at the bottom the the new arbitrary height value REPOSITORY R169 Kirigami BRANCH handle-follow-drawer (branched from master) REVISION DETAIL https://phabricator.kde.org/D22648 AFFECTED FILES src/controls/templates/OverlayDrawer.qml To: camiloh, mart Cc: camiloh, plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein
