D22728: Provide a link to KInfoCenter

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Did D22742  instead.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22728

To: ngraham, #plasma, #vdg
Cc: cfeck, mthw, mmustac, broulik, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22728: Provide a link to KInfoCenter

[Nathaniel Graham]

ngraham added a comment.


  And here's the patch for the alternative approach: 
https://phabricator.kde.org/D22742

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22728

To: ngraham, #plasma, #vdg
Cc: cfeck, mthw, mmustac, broulik, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22728: Provide a link to KInfoCenter

[Christoph Feck]

cfeck added a comment.


  +1 for putting it in the Help menu.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22728

To: ngraham, #plasma, #vdg
Cc: cfeck, mthw, mmustac, broulik, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22728: Provide a link to KInfoCenter

[Matej Mrenica]

mthw added a comment.


  I personally like the alternative aproach, as it is what I had in mind when 
submitting the bug report.
  
  > - There isn't really a 100% appropriate parent category to put it in
  
  It could be the last item in the Hardware section. Also, IIRC Gnome does it 
like this (not that we should copy Gnome or anything, it just feels intuitive).

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22728

To: ngraham, #plasma, #vdg
Cc: mthw, mmustac, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22728: Provide a link to KInfoCenter

[Marijo Mustac]

mmustac added a comment.


  In D22728#501819 , @ngraham wrote:
  
  > An alternative approach would be to simply show KCM itself in System 
Settings by adding `X-KDE-System-Settings-Parent-Category=` to the 
`about-dostro.desktop` file that KInfoCenter ships:
  >
  > F7092747: Alternative: as a KCM.png 
  >
  > This makes it more discoverable when using Sidebar view, but has some 
disadvantages:
  >
  > - There isn't really a 100% appropriate parent category to put it in
  > - Visiting the KCM within System Settings doesn't expose all the 
information available in KInfoCenter's other pages. I suppose we could add a 
Show More Information button to this KCM when it's opened in something other 
than KInfoCenter if we wanted to pursue the alternative approach instead of the 
one in this patch.
  
  
  I really like this integrated approach.
  While I have no access to linux or Plasma at the moment ... but when I 
remember correctly there could appear a "system administration" category when 
installing the systemd-kcm for example.
  F7094390: KDE_5_System_Settings_on_Fedora_22_no_user_account.png 


REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22728

To: ngraham, #plasma, #vdg
Cc: mmustac, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22728: Provide a link to KInfoCenter

[Kai Uwe Broulik]

broulik added a comment.


  +1 to the idea

INLINE COMMENTS

> SettingsBase.cpp:151
> +systemInformationAction = actionCollection()->addAction( 
> QStringLiteral("help_about_system"), this, [] () {
> +KRun::runCommand( QStringLiteral("kinfocenter"), nullptr );
> +} );

Can you do `runApplication` with `org.kde.kinfocenter` service, then you can 
also just read the icon etc from there

Also, perhaps check if it is installed?

> SettingsBase.cpp:402
>  QList configureBarActions;
> -configureBarActions << configureAction;
> +configureBarActions << configureAction << systemInformationAction;
>  guiFactory()->plugActionList( this, QStringLiteral("configure"), 
> configureBarActions );

Not sure about having a bigass button with wide text in the toolbar at all times

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D22728

To: ngraham, #plasma, #vdg
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22728: Provide a link to KInfoCenter

[Nathaniel Graham]

ngraham updated this revision to Diff 62508.
ngraham added a comment.


  Code style++

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22728?vs=62507=62508

BRANCH
  link-to-kinfocenter (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22728

AFFECTED FILES
  app/SettingsBase.cpp
  app/SettingsBase.h
  sidebar/package/contents/ui/CategoriesPage.qml

To: ngraham, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart