D22734: Support displaying emoticons in connection name and SSID

2019-07-25 Thread Jan Grulich
jgrulich abandoned this revision.
jgrulich added a comment.


  In D22734#502034 , @broulik wrote:
  
  > -1 to dragging in KEmoticons for that.
  >  Aren't they just unicode Emojis which we can render just fine elsewhere.
  
  
  You are right, I can display them just fine. I should have tried that before.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22734

To: jgrulich, #plasma
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D22734: Support displaying emoticons in connection name and SSID

2019-07-25 Thread Kai Uwe Broulik
broulik added a comment.


  -1 to dragging in KEmoticons for that.
  Aren't they just unicode Emojis which we can render just fine elsewhere.

INLINE COMMENTS

> DetailsText.qml:84
>  text: "" + details[index*2] + ": "
> +textFormat: Text.StyledText
>  

Since there are HTML tags already, it defaults to `StyledText` already, but it 
doesn't hurt to be explicit

> DetailsText.qml:106
>  text: details[(index*2)+1]
> -textFormat: Text.PlainText
> +textFormat: Text.StyledText
>  

Make sure the text is HTML-escaped

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22734

To: jgrulich, #plasma
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart