D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-09-17 Thread Jonathan Marten 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:eed2d620cbd5: Consistent virtual desktop numbering 
between Switch Window popup and taskbar (authored by marten).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22740?vs=66138=66277

REVISION DETAIL
  https://phabricator.kde.org/D22740

AFFECTED FILES
  containmentactions/switchwindow/switch.cpp

To: marten, #plasma, #kwin, zzag
Cc: zzag, GB_2, ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-09-15 Thread Vlad Zahorodnii 
zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  In D22740#513873 , @marten wrote:
  
  > @GB_2 thanks for testing;  a desktop UUID is obviously not friendly to show 
to the user, so there needs to be some sort of X11/Wayland runtime check here.
  
  
  Yes, that's right, KWin will generate a UUID for each new virtual desktop.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

To: marten, #plasma, #kwin, zzag
Cc: zzag, GB_2, ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-09-15 Thread Jonathan Marten 
marten updated this revision to Diff 66138.
marten added a comment.


  Ignore the desktop ID and simply use the loop index, adjusted so that the 
desktop numbers start at 1.  This is the same formatting as used by KWin 
(kwin/useractions.cpp) and the Task Manager applet 
(plasma-desktop/applets/taskmanager/package/contents/ui/ContextMenu.qml).  This 
should work as intended on both X11 and Wayland.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22740?vs=62545=66138

REVISION DETAIL
  https://phabricator.kde.org/D22740

AFFECTED FILES
  containmentactions/switchwindow/switch.cpp

To: marten, #plasma
Cc: GB_2, ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-08-18 Thread Jonathan Marten 
marten planned changes to this revision.
marten added a comment.


  @GB_2 thanks for testing;  a desktop UUID is obviously not friendly to show 
to the user, so there needs to be some sort of X11/Wayland runtime check here.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

To: marten, #plasma
Cc: GB_2, ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-08-17 Thread Björn Feber 
GB_2 added a comment.


  I just tried it on Wayland and it looks like for some reason instead of a 
number it shows some kind of UUID.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

To: marten, #plasma
Cc: GB_2, ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-08-17 Thread Nathaniel Graham 
ngraham added a comment.


  Cool, thanks. Once it's verified on Wayland, we can change `CCBUG:` to `BUG:`.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

To: marten, #plasma
Cc: ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-08-17 Thread Jonathan Marten 
marten added a comment.


  In D22740#512556 , @ngraham wrote:
  
  > So does this fully fix 410190, or only partially?
  
  
  Fixes it completely for X11.
  Should really verify on Wayland before considering the bug to be completely 
fixed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

To: marten, #plasma
Cc: ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-08-15 Thread Nathaniel Graham 
ngraham added a comment.


  So does this fully fix 410190, or only partially?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

To: marten, #plasma
Cc: ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-08-15 Thread Christoph Feck 
cfeck added a comment.


  Could someone test this on Wayland? The fix itself looks trivial, but if it 
breaks Wayland session, it obviously needs to be changed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

To: marten, #plasma
Cc: cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-07-25 Thread Jonathan Marten 
marten created this revision.
marten added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
marten requested review of this revision.

REVISION SUMMARY
  Bug https://bugs.kde.org/show_bug.cgi?id=410190 describes the inconsistent 
virtual desktop numbering between the Switch Window popup and the taskbar Move 
To Desktop list.  This patch fixes the Switch Window popup to use the more 
natural (to the user) 1-based desktop IDs.
  
  According to virtualdesktopinfo.h, a desktop ID on Wayland is a QString while 
on X11 it is a uint.  Therefore using toString() here for correct formatting of 
the desktop ID on both X11 and Wayland.

TEST PLAN
  Built plasma-workspace with this change, observed correct and consistent 
desktop numbering in both these places.  Not yet able to test on Wayland.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22740

AFFECTED FILES
  containmentactions/switchwindow/switch.cpp

To: marten, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart