D22742: Show about distro KCM in System Settings' System Administration category

[Nathaniel Graham]

ngraham added a comment.


  File a bug on KInfoCenter :)

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D22742

To: ngraham, #vdg, #plasma, filipf, GB_2
Cc: KonqiDragon, mthw, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22742: Show about distro KCM in System Settings' System Administration category

[KonqiDragon]

KonqiDragon added a comment.


  Can add a GPU information in **Hardware**?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D22742

To: ngraham, #vdg, #plasma, filipf, GB_2
Cc: KonqiDragon, mthw, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22742: Show about distro KCM in System Settings' System Administration category

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:09598972736b: Show about distro KCM in System 
Settings System Administration category (authored by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22742?vs=62560=62940#toc

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22742?vs=62560=62940

REVISION DETAIL
  https://phabricator.kde.org/D22742

AFFECTED FILES
  Modules/about-distro/src/about-distro.desktop

To: ngraham, #vdg, #plasma, filipf, GB_2
Cc: mthw, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22742: Show about distro KCM in System Settings' System Administration category

[Nathaniel Graham]

ngraham added a comment.


  Yeah I slightly prefer it as well, for just that reason.

REPOSITORY
  R102 KInfoCenter

BRANCH
  show-about-distro-kcm-in-systemsettings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22742

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22742: Show about distro KCM in System Settings' System Administration category

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  +1 for the feature, with how everyone is used to phones nowadays, I think a 
fair share of users would expect to see this information in system settings.
  
  I like this approach more than the other one primarily because of the reason 
no.1 you listed - it's more discoverable.
  
  Tested it out as well and it works fine.

REPOSITORY
  R102 KInfoCenter

BRANCH
  show-about-distro-kcm-in-systemsettings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22742

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22742: Show about distro KCM in System Settings' System Administration category

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This is an alternative to D22728 . It 
makes the System Information KCM appear in
  System Settings' System Administration section.
  
  Advantages over D22728 :
  
  - The information is more discoverable
  - It automatically disappears if KInfoCenter is not installed or removed
  - It requires no changes to SystemSettings' fragile codebase
  
  Disadvantages:
  
  - Since it doesn't open KInfoCenter or have a link to it, all the other 
information in KInfoCenter is not exposed
  - If we do later want to adjust this KCM to have a button to open KInfoCenter 
when pushed, we'll hit https://bugs.kde.org/show_bug.cgi?id=410169 since the 
KCM will be already open in System Settings

TEST PLAN
  F7096717: in systemsettings.png 

REPOSITORY
  R102 KInfoCenter

BRANCH
  show-about-distro-kcm-in-systemsettings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22742

AFFECTED FILES
  Modules/about-distro/src/about-distro.desktop

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart