D22748: whitelist the "turn off screen" shortcut on the lock screen

[Martin Blumenstingl]

This revision was automatically updated to reflect the committed changes.
Closed by commit R133:5ed0dc17f3f9: Allow the turn off screen to be 
used from the lockscreen (authored by mblumenstingl).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22748?vs=62570=62637

REVISION DETAIL
  https://phabricator.kde.org/D22748

AFFECTED FILES
  globalaccel.cpp

To: mblumenstingl, broulik, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22748: whitelist the "turn off screen" shortcut on the lock screen

[Martin Blumenstingl]

mblumenstingl added a comment.


  In D22748#502337 , @mblumenstingl 
wrote:
  
  > I did some more digging and I now believe that I'm facing a problem that's 
related to me running wayland.
  >
  > 
https://github.com/KDE/kwindowsystem/blob/05f5379c24a59e1ded2f12a6fd09946617abd0ac/src/kkeyserver.h#L29
  >  KKeyServer has a compile-time switch for it's backend.
  >  I guess this needs to be converted to a runtime switch similar to what was 
done here 
https://github.com/KDE/kguiaddons/commit/0fe2990dbad992a4925a7b7bee09b1cdfbe5a7a7#diff-928c366533ef47aba95b92e8767bc8ff
  
  
  there's even a task on phabricator for this: T4423 


REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D22748

To: mblumenstingl, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22748: whitelist the "turn off screen" shortcut on the lock screen

[Martin Blumenstingl]

mblumenstingl added a comment.


  I did some more digging and I now believe that I'm facing a problem that's 
related to me running wayland.
  
  
https://github.com/KDE/kwindowsystem/blob/05f5379c24a59e1ded2f12a6fd09946617abd0ac/src/kkeyserver.h#L29
  KKeyServer has a compile-time switch for it's backend.
  I guess this needs to be converted to a runtime switch similar to what was 
done here 
https://github.com/KDE/kguiaddons/commit/0fe2990dbad992a4925a7b7bee09b1cdfbe5a7a7#diff-928c366533ef47aba95b92e8767bc8ff

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D22748

To: mblumenstingl, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22748: whitelist the "turn off screen" shortcut on the lock screen

[Martin Blumenstingl]

mblumenstingl created this revision.
mblumenstingl added a reviewer: broulik.
mblumenstingl added a project: Plasma.
mblumenstingl requested review of this revision.

REVISION SUMMARY
  This is a follow-up to D22261 
  
  unfortunately the test plan is not working for me:
  when I press the global shortcut on the lock screen then the display does not 
turn off.
  however, this is not related to the new global action because "volume up", 
"volume down", "mute" and "play pause" are also not working for me on the lock 
screen

TEST PLAN
  start a plasma wayland session
  open systemsettings5 -> Shortcuts -> Global Shortcuts -> Power Management
  assign a shortcut to "Turn Off Screen"
  press this shortcut
  (screen must now turn off -> this confirms that the shortcut is working)
  move the mouse or press a key to turn the screen back on
  lock the screen
  press the global shortcut again
  (screen must now turn off)

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D22748

AFFECTED FILES
  globalaccel.cpp

To: mblumenstingl, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart