D22757: Guard against missing xrandr extension

2019-07-26 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> screenpool.cpp:46
>  if (KWindowSystem::isPlatformX11()) {
>  qApp->installNativeEventFilter(this);
>  const xcb_query_extension_reply_t* reply = 
> xcb_get_extension_data(QX11Info::connection(), _randr_id);

How about not installing the event filter in this case in the first place?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22757

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22757: Guard against missing xrandr extension

2019-07-25 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Found from a user doing something wrong with their wayland session, but
  it could still happen.
  
  BUG: 410211

TEST PLAN
  None

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22757

AFFECTED FILES
  shell/screenpool.cpp
  shell/screenpool.h

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart