D22976: Fix compilation

2019-08-10 Thread Ömer Fadıl Usta
usta added a comment.


  In D22976#509675 , @aacid wrote:
  
  > And what are you or ben waiting for? You've both got commit access :)
  
  
  @aacid:
  ;) in here we are in sacrifice feast , and i dont have my laptop with me  ( 
sorry about that )
  
  And @ngraham thank you

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22976

To: ngraham, #plasma, aacid
Cc: usta, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D22976: Fix compilation

2019-08-10 Thread Nathaniel Graham
ngraham added a comment.


  Done.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22976

To: ngraham, #plasma, aacid
Cc: usta, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D22976: Fix compilation

2019-08-10 Thread Albert Astals Cid
aacid added a comment.


  And what are you or ben waiting for? You've both got commit access :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22976

To: ngraham, #plasma, aacid
Cc: usta, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D22976: Fix compilation

2019-08-09 Thread Ömer Fadıl Usta
usta added a comment.


  ben mentioned that this also needs to be cherrypicked to stable branch too.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22976

To: ngraham, #plasma, aacid
Cc: usta, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D22976: Fix compilation

2019-08-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0c4ec1c4af05: Fix compilation (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22976?vs=63222=63223

REVISION DETAIL
  https://phabricator.kde.org/D22976

AFFECTED FILES
  runners/windows/windowsrunner.h

To: ngraham, #plasma, aacid
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22976: Fix compilation

2019-08-06 Thread Nathaniel Graham
ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Without this patch, plasma-workspace fails to compile for me with the 
following error:
  
In file included from 
/home/nate/kde/build/plasma-workspace/runners/windows/krunner_windows_autogen/EWIEGA46WW/moc_windowsrunner.cpp:10,
 from 
/home/nate/kde/build/plasma-workspace/runners/windows/krunner_windows_autogen/mocs_compilation.cpp:2:

/home/nate/kde/build/plasma-workspace/runners/windows/krunner_windows_autogen/EWIEGA46WW/../../../../../../src/plasma-workspace/runners/windows/windowsrunner.h:61:9:
 error: ‘QMutex’ does not name a type
   61 | QMutex m_mutex;
  | ^~

TEST PLAN
  It compiles now

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-compilation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22976

AFFECTED FILES
  runners/windows/windowsrunner.h

To: ngraham, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart