D23044: [Notifications] Swing the bell when there is a new notification

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6e067d12d246: [Notifications] Swing the bell when there 
is a new notification (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23044?vs=63405=63412

REVISION DETAIL
  https://phabricator.kde.org/D23044

AFFECTED FILES
  applets/notifications/package/contents/ui/CompactRepresentation.qml

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, shubham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23044: [Notifications] Swing the bell when there is a new notification

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  OMG that's so cute!!! I kind of love it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23044

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, shubham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23044: [Notifications] Swing the bell when there is a new notification

[Shubham]

shubham added a comment.


  Personally I do not like info button to be swung like a bell, however VDG are 
the right people to decide  this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23044

To: broulik, #plasma, #vdg
Cc: shubham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23044: [Notifications] Swing the bell when there is a new notification

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When switching to "unread" state, animate the bell icon.
  It only animates for the transition to unread so you can see where it's 
going, but not every time a notification comes in, as that would be annoying.

TEST PLAN
  F7181500: bell.mp4 
  Even when it's not a bell it looks kinda cute
  F7181502: bell2.mp4 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23044

AFFECTED FILES
  applets/notifications/package/contents/ui/CompactRepresentation.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart