D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-11-12 Thread Carson Black 
cblack abandoned this revision.
cblack added a comment.


  See D25281 .

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23079

To: cblack, #vdg, #breeze, ngraham
Cc: mthw, ngraham, zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-11-12 Thread Nathaniel Graham 
ngraham added a comment.


  Can you rebase this?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23079

To: cblack, #vdg, #breeze, ngraham
Cc: mthw, ngraham, zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-13 Thread Carson Black 
cblack updated this revision to Diff 63676.
cblack added a comment.


  Tweak colors some more

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23079?vs=63515=63676

BRANCH
  firefox-csd-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23079

AFFECTED FILES
  src/gtk3/applications/_firefox.scss
  src/gtk3/gtk.scss

To: cblack, #vdg, #breeze, ngraham
Cc: mthw, ngraham, zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This also happens with Thunderbird too. I think we need to go back to the 
earlier version, come up with something different or fix Firefox itself. :/

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23079

To: cblack, #vdg, #breeze, ngraham
Cc: ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Nathaniel Graham 
ngraham added a comment.


  And it really really really doesn't work with Wonton soup at all:
  
  F7203531: Screenshot_20190810_171455.png 


REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23079

To: cblack, #vdg, #breeze
Cc: ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Nathaniel Graham 
ngraham added a comment.


  With certain color schemes, this new style looks... special. :)
  
  Oxygen: F7203525: Oxygen.png 
  
  Honeycomb: F7203526: Honeycomb.png 

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23079

To: cblack, #vdg, #breeze
Cc: ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Nathaniel Graham 
ngraham added a comment.


  Hmm, now the rest of the tab bar and menubar backgrounds have started to use 
the titlebar color:
  
  F7203516: Screenshot_20190810_170538.png 

  
  It's not a terrible look, but I'm not sure it's intended...

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23079

To: cblack, #vdg, #breeze
Cc: ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Nathaniel Graham 
ngraham added a comment.


  Hmm, definitely looks better with CSDs, but with SSDs, this happens:
  
  F7203504: Screenshot_20190810_170312.png 

  
  I could live with the inactive tab titles getting lighter, but not the 
menubar.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23079

To: cblack, #vdg, #breeze
Cc: ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Carson Black 
cblack updated this revision to Diff 63515.
cblack added a comment.


  Add background color to make SSD decorations more legible with patch

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23079?vs=63514=63515

BRANCH
  firefox-csd-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23079

AFFECTED FILES
  src/gtk3/applications/_firefox.scss
  src/gtk3/gtk.scss

To: cblack, #vdg, #breeze
Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Vlad Zagorodniy 
zzag added a comment.


  How does it look when Firefox has a server side-decoration?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23079

To: cblack, #vdg, #breeze
Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Carson Black 
cblack created this revision.
cblack added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  This fixes the CSD colors of Firefox to be more legible, but not without some 
caveats due to upstream issues.
  
  - The inactive titlebar foreground color is used regardless of window state.
  - #MozillaGtkWidget does not have any visible way to discriminate between CSD 
on and CSD off unlike normal GTK windows, so any style changes apply to both.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  firefox-csd-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23079

AFFECTED FILES
  src/gtk3/applications/_firefox.scss
  src/gtk3/gtk.scss

To: cblack, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart