D23158: [Kickoff] Improve appearance of draggable button grid in settings window

2019-09-26 Thread Nathaniel Graham 
ngraham updated this revision to Diff 66922.
ngraham added a comment.


  Squash changes from D24251 

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23158?vs=66916=66922

BRANCH
  improve-kickoff-settings-button-grid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23158

AFFECTED FILES
  applets/kickoff/package/contents/ui/ConfigButtons.qml
  applets/kickoff/package/contents/ui/ConfigGeneral.qml
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml

To: ngraham, #vdg, #plasma, davidedmundson, GB_2, hein
Cc: hein, GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

2019-09-26 Thread Nathaniel Graham 
ngraham updated this revision to Diff 66916.
ngraham added a comment.


  Rebase again

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23158?vs=66915=66916

BRANCH
  improve-kickoff-settings-button-grid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23158

AFFECTED FILES
  applets/kickoff/package/contents/ui/ConfigButtons.qml
  applets/kickoff/package/contents/ui/ConfigGeneral.qml
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml

To: ngraham, #vdg, #plasma, davidedmundson, GB_2, hein
Cc: hein, GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

2019-09-26 Thread Nathaniel Graham 
ngraham updated this revision to Diff 66915.
ngraham added a comment.


  Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23158?vs=63756=66915

BRANCH
  improve-kickoff-settings-button-grid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23158

AFFECTED FILES
  applets/kickoff/package/contents/ui/ConfigButtons.qml
  applets/kickoff/package/contents/ui/ConfigGeneral.qml
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml
  containments/panel/contents/ui/main.qml
  toolboxes/paneltoolbox/contents/ui/main.qml

To: ngraham, #vdg, #plasma, davidedmundson, GB_2, hein
Cc: hein, GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

2019-09-20 Thread Nathaniel Graham 
ngraham added a comment.


  @davidedmundson this missed 5.17. I could still use a hand with the changes 
you requested to land this in 5.18.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23158

To: ngraham, #vdg, #plasma, davidedmundson, GB_2, hein
Cc: hein, GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

2019-08-31 Thread Nathaniel Graham 
ngraham added a comment.


  Ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23158

To: ngraham, #vdg, #plasma, davidedmundson, GB_2
Cc: GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

2019-08-24 Thread Nathaniel Graham 
ngraham added a comment.


  @davidedmundson ping. I fixed one issue but may need a bit of help for the 
one about the weird sizing for the button grid component.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23158

To: ngraham, #vdg, #plasma, davidedmundson, GB_2
Cc: GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

2019-08-16 Thread Björn Feber 
GB_2 accepted this revision as: VDG, GB_2.
GB_2 added a comment.


  Visually +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23158

To: ngraham, #vdg, #plasma, davidedmundson, GB_2
Cc: GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

2019-08-14 Thread Nathaniel Graham 
ngraham updated this revision to Diff 63756.
ngraham added a comment.


  Use Layout.preferred[Width|Height]

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23158?vs=63748=63756

BRANCH
  improve-kickoff-settings-button-grid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23158

AFFECTED FILES
  applets/kickoff/package/contents/ui/ConfigButtons.qml
  applets/kickoff/package/contents/ui/ConfigGeneral.qml
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

2019-08-14 Thread Nathaniel Graham 
ngraham marked an inline comment as done.
ngraham added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ConfigGeneral.qml:124
> What's this about? It's typically a sign that something else is wrong.
> 
> Probably the lack of spacer in this dialog means the label below occupies 
> quite large box that it's in the middle of.
> 
> Try aligning the label below to the top instead.

The reason is actually because of the weird way that the inline labels are 
positioned in `ConfigButtons` which causes the component to have no spacing 
above it, but extra spacing below it. Definitely open to fixing that, but I 
couldn't figure out how.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23158

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

2019-08-14 Thread David Edmundson 
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Intention makes sense, as do most the changes. Just some minor comments.

INLINE COMMENTS

> ConfigGeneral.qml:124
> +Layout.topMargin: units.gridUnit
> +Layout.bottomMargin: -units.gridUnit
>  }

What's this about? It's typically a sign that something else is wrong.

Probably the lack of spacer in this dialog means the label below occupies quite 
large box that it's in the middle of.

Try aligning the label below to the top instead.

> KickoffConfigurationButton.qml:45
> +Layout.alignment: Qt.AlignHCenter
> +width: units.iconSizes.medium
> +height: width

It's almost always wrong to specify a width inside a ColumnLayout.

use implicitWidth or Layout.preferredWidth

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23158

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

2019-08-14 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The button grid was not centered, the content inside the buttons was not 
centered, the
  vertical spacing was too high on top and too low on bottom, and the 
explanatory text
  got cut off.
  
  This patch solves all those problems.
  
  BUG: 409957
  FIXED-IN: 5.17.0

TEST PLAN
  Before: F7247447: Before.png 
  After: F7247446: After.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-kickoff-settings-button-grid (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23158

AFFECTED FILES
  applets/kickoff/package/contents/ui/ConfigButtons.qml
  applets/kickoff/package/contents/ui/ConfigGeneral.qml
  applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart