D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

2019-12-12 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5174aa9e1a29: Add grouping and Show Only 
Minimized options to icons-only task manager (authored by GB_2, committed 
by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23242?vs=63979=71396

REVISION DETAIL
  https://phabricator.kde.org/D23242

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, hein, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

2019-12-12 Thread Eike Hein 
hein added a comment.


  Let's go for it, it's fairly in line with the TM applet refectoring we 
planned in Valencia at the end of the day

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23242

To: GB_2, #plasma, #vdg, hein, ngraham
Cc: ngraham, hein, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

2019-12-10 Thread Nathaniel Graham 
ngraham added a comment.


  FWIW the bug this fixes (https://bugs.kde.org/show_bug.cgi?id=368430) is 
starting to accumulate duplicates. There seems to be some user demand for this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23242

To: GB_2, #plasma, #vdg, hein, ngraham
Cc: ngraham, hein, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

2019-11-16 Thread Björn Feber 
GB_2 added a comment.


  @hein If you really still think we shouldn't do this then I can change this 
patch to only affect the "Show Only Minimized" option and close the bug as 
INTENTIONAL.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23242

To: GB_2, #plasma, #vdg, hein, ngraham
Cc: ngraham, hein, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

2019-10-21 Thread Björn Feber 
GB_2 added a comment.


  Ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23242

To: GB_2, #plasma, #vdg, hein, ngraham
Cc: ngraham, hein, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

2019-08-26 Thread Björn Feber 
GB_2 added a comment.


  Ping @hein

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23242

To: GB_2, #plasma, #vdg, hein, ngraham
Cc: ngraham, hein, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

2019-08-19 Thread Björn Feber 
GB_2 added a comment.


  In D23242#514239 , @hein wrote:
  
  > Code's fine, but let's discuss the change briefly - disabling grouping in 
ITM gets you a bunch of identical-looking icons you can't tell apart. I think 
that's a pretty ugly user experience, does it make sense to have an option to 
configure the applet into an invariably sort of unpleasant to use state? That's 
why I resisted it in the past.
  
  
  There's already the option to disable grouping for specific apps. Having an 
option to disable it for all aps is a feature that gets requested from time to 
time and you can get it on for example Cinnamon, LXDE/LXQt or Windows with 
registry edit tweaks.
  Also:
  
  - it is not an issue if you have a pretty consistent set of windows open, so 
you just remember which is which
  - you can tell from tooltip
  - just let the user decide
  
  I personally would use this feature.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23242

To: GB_2, #plasma, #vdg, hein, ngraham
Cc: ngraham, hein, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

2019-08-18 Thread Eike Hein 
hein added a comment.


  Code's fine, but let's discuss the change briefly - disabling grouping in ITM 
gets you a bunch of identical-looking icons you can't tell apart. I think 
that's a pretty ugly user experience, does it make sense to have an option to 
configure the applet into an invariably sort of unpleasant to use state? That's 
why I resisted it in the past.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23242

To: GB_2, #plasma, #vdg, hein, ngraham
Cc: ngraham, hein, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

2019-08-18 Thread Nathaniel Graham 
ngraham added subscribers: hein, ngraham.
ngraham added a reviewer: hein.
ngraham accepted this revision.
ngraham added a comment.


  +1, but wait for @hein.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23242

To: GB_2, #plasma, #vdg, hein, ngraham
Cc: ngraham, hein, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

2019-08-18 Thread Björn Feber 
GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  BUG: 368430
  Being able to disable grouping for the icons-only taskmanager makes sense, 
because it has enough space to hold plenty of application icons/launchers. The 
"Show only tasks that are minimized" option is useful as well for the IOTM.
  F7258179: Added Grouping and Show Only Minimized Options in Icons-only Task 
Manager.png 

TEST PLAN
  Open the IOTM behavior settings page. Enable/disable grouping and toggle the 
"Show only tasks that are minimized" option.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-grouping-and-show-only-minimized-options-to-icon-only-task-manager 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23242

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart