D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> GB_2 wrote in main.qml:27
> Is this actually used? Also, because it's not installed by default it shows 
> an error.

Fixed in 
https://commits.kde.org/plasma-desktop/659a46aac39789c40e8cd07060e3bacd5fe8d461

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> main.qml:27
> +import org.kde.kcm 1.1 as KCM
> +import Qt.labs.platform 1.1
> +

Is this actually used? Also, because it's not installed by default it shows an 
error.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d66bd8f3e9af: WIP: Beginning of the Baloo/Search KCM 
Rewrite (authored by tcanabrava).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=67572=67701

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM! Would be nice to fix some of these bugs in follow-up patches too: 
https://bugs.kde.org/buglist.cgi?component=kcm_baloo_id=1669138=systemsettings=---

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 67572.
tcanabrava added a comment.


  - Fix Strings
  - Fix margins

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=67568=67572

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Nathaniel Graham]

ngraham added a comment.


  Almost done, just a tiny bit of polish is needed! See inline comments:

INLINE COMMENTS

> kcm.cpp:61
>  KAboutData* about = new KAboutData(
>  QStringLiteral("kcm_baloofile"), i18n("Configure File Search"),
>  QStringLiteral("0.1"), QString(), KAboutLicense::GPL,

Make this match the name shown in the list ("File Search")

> main.qml:32
> +
> +KCM.ConfigModule.quickHelp: i18n("This module lets you configure the 
> search in the system.")
> +ColumnLayout {

"This module lets you configure the file indexer and search functionality."

> main.qml:36
> +Layout.leftMargin:  Kirigami.Units.smallSpacing * 2
> +Layout.rightMargin: Kirigami.Units.smallSpacing * 2
> +

This item isn't inside a Layout, so `Layout.` has no effect. You want 
`anchors.` instead.

Also the margins should be `Kirigami.Units.largeSpacing`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava marked 2 inline comments as done.
tcanabrava added a comment.


  I still need to play a bit with the folder save / load. the code from the old 
kcm is quite strange. it saves "included folders", but there's nothing using 
that. perhaps it's safer if we just remove everything that's not used.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 67568.
tcanabrava added a comment.


  - fix Comment

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=67567=67568

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 67567.
tcanabrava marked 7 inline comments as done.
tcanabrava added a comment.


  - Simplify Checkboxes
  - Fix previouslyEnabled logic
  - Tell Qml that we have the values
  - Move code around
  - Fix QSet math
  - Qml gives us a Url, we want the Local file
  - use folderAdded and folderRemoved
  - Remove debug information
  - Add spacing

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=67563=67567

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  See inline comments.
  
  Also functionality-wise there are some problems:
  
  1. When a new entry is added, if the KCM is closed and re-opened, the new 
entry has been forgotten
  2. When you add a path, the ugly URL schema bit doesn't get stripped off like 
it should: F7556828: Screenshot_20191009_090737.png 


INLINE COMMENTS

> filteredfoldermodel.cpp:147
> +
> +Q_FOREACH (const QString& mount, m_mountPoints) {
> +if (url.startsWith(mount) && mount.size() > mountPoint.size())

Don't use Q_FOREACH in new or ported code

> main.qml:23
> +import QtQuick.Layouts 1.1
> +import QtQuick.Controls 2.12 as QQC2
> +import QtQuick.Dialogs 1.2 as QtDialogs

IIRC plasma isn't depending on Qt 5.12 yet, right?

> main.qml:39
> +QQC2.Label {
> +text: i18n("File Search helps you quickly locate all your files 
> based on their content")
> +}

This is a sentence, so it needs to end with a period.

> main.qml:47
> +onCheckStateChanged: {
> +if (!checkState === Qt.Unchecked) {
> +indexFileContents.checked = false;

This can be simplified to just `if (!checked)`

> main.qml:50
> +}
> +kcm.indexing = fileSearchEnabled.checked
> +}

Don't need to reference it with `fileSearchEnabled`, just do `kcm.indexing = 
checked`

> main.qml:53
> +
> +Component.onCompleted : {
> +fileSearchEnabled.checked = kcm.indexing ? Qt.Checked : 
> Qt.Unchecked

Don't do it this way, just use a binding:

`checked: kcm.indexing`

> main.qml:69
> +indexFileContents.checked = kcm.fileContents ? Qt.Checked : 
> Qt.Unchecked
> +}
> +}

Same comments as with the first checkbox

> main.qml:71
> +}
> +
> +QQC2.Label {

I would add some spacing between the last checkbox and the list view's 
explanatory label:

  Item {
  Layout.preferredHeight: Kirigami.Units.gridUnit
  }

> GB_2 wrote in main.qml:2
> Shouldn't this be you copyright?

Not done yet

> nicolasfella wrote in metadata.desktop:3
> That comment sounds wrong :)

Not done yet

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 67563.
tcanabrava added a comment.


  - Fix metadata installation
  - Fix model loading on Qml
  - Base work on the Qml
  - Name fixes
  - Move ui/main to contents
  - Fix wrong types in Qml
  - Plug the controllers
  - Link to the save button
  - Fix borders and background for the Baloo KCM
  - Use kirigami BasicListItem
  - Spacing
  - Fix mapping of roles
  - Fix delegate / Mouse integration

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=66643=67563

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Björn Feber]

GB_2 added a comment.


  Relevant: https://bugs.kde.org/show_bug.cgi?id=351647

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava added a comment.


  got it, updating.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Björn Feber]

GB_2 added a comment.


  In D23718#536359 , @ngraham wrote:
  
  > The frame's alignment and padding seem off: F7416705: 
Screenshot_20190923_075306.png 
  >
  > Could we use a list more like the one used in the Virtual Desktops KCM and 
the slideshow wallpaper folder list? Then we would have a unified appearance 
(#consistency  :) ).
  
  
  Yeah, use a Kirigami BasicListItem.

INLINE COMMENTS

> main.qml:2
> +/*
> + * Copyright 2018 Kai Uwe Broulik 
> + *

Shouldn't this be you copyright?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Nathaniel Graham]

ngraham added a comment.


  The frame's alignment and padding seem off: F7416705: 
Screenshot_20190923_075306.png 
  
  Could we use a list more like the one used in the Virtual Desktops KCM and 
the slideshow wallpaper folder list? Then we would have a unified appearance 
(#consistency  :) ).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: nicolasfella, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> metadata.desktop:3
> +Name=Search
> +Comment=Choose color scheme
> +

That comment sounds wrong :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: nicolasfella, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 66643.
tcanabrava added a comment.


  - Fix metadata installation
  - Fix model loading on Qml
  - Base work on the Qml
  - Name fixes
  - Move ui/main to contents
  - Fix wrong types in Qml
  - Plug the controllers
  - Link to the save button
  - Fix borders and background for the Baloo KCM

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=66258=66643

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma, mart, ngraham
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This isn't ready yet without, at a minimum, the UI change I requested for the 
list view.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma, mart, ngraham
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Nathaniel Graham]

ngraham added a comment.


  FWIW, it would be good to fix some of the bugs listed here as part of the 
port: 
https://bugs.kde.org/buglist.cgi?component=kcm_baloo_id=1663634=systemsettings=---

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Nathaniel Graham]

ngraham added a comment.


  Getting there!
  
  Use an actual framed list view for the list of folders to not index, like the 
current one has.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava, #plasma
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 66258.
tcanabrava added a comment.


  - Fix metadata installation
  - Fix model loading on Qml
  - Base work on the Qml
  - Name fixes
  - Move ui/main to contents
  - Fix wrong types in Qml
  - Plug the controllers
  - Link to the save button

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=65378=66258

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop

To: tcanabrava, #plasma
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 65378.
tcanabrava added a comment.


  - Name fixes

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=65375=65378

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/metadata.desktop
  kcms/baloo/package/ui/main.qml

To: tcanabrava
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 65375.
tcanabrava added a comment.


  - Fix metadata installation
  - Fix model loading on Qml
  - Base work on the Qml

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23718?vs=65369=65375

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/metadata.desktop
  kcms/baloo/package/ui/main.qml

To: tcanabrava
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> main.qml:31
> +
> +KCM.ConfigModule.quickHelp: i18n("This module lets you configure the 
> search in the system.")
> +

While we're at it, let's improve this string:

"This module lets you configure the system-wide file search features"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Marco Martin]

mart added a comment.


  please, include screenshots

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> main.qml:33
> +
> +QtControls.Label {
> +text: i18n("File Search helps you quickly locate all your files 
> based on their content")

should use a Kirigami.FormLayout to have checkboxes centered?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> main.qml:23
> +import QtQuick.Layouts 1.1
> +import QtQuick.Controls 2.0 as QtControls
> +import QtQuick.Dialogs 1.2 as QtDialogs

`import QtQuick.Controls 2.5 as QQC2` (See T10862 
)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23718

To: tcanabrava
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm_baloo_qml

REVISION DETAIL
  https://phabricator.kde.org/D23718

AFFECTED FILES
  kcms/baloo/CMakeLists.txt
  kcms/baloo/configwidget.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/folderselectionwidget.cpp
  kcms/baloo/folderselectionwidget.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/metadata.desktop
  kcms/baloo/package/ui/main.qml

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart