D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-20 Thread Filip Fila 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6b4295b313af: [applets/taskmanager] Revert 
forceStripes checkbox string change (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24534?vs=67609=68381

REVISION DETAIL
  https://phabricator.kde.org/D24534

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml

To: filipf, #plasma, #vdg, aspotashev, ngraham
Cc: #localization, jriddell, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-17 Thread Alexander Potashev 
aspotashev added a comment.


  Before pushing new i18n strings into stable branches, you need to ask for 
permission in https://mail.kde.org/mailman/listinfo/kde-i18n-doc
  
  Altough one translator's approval is enough, writing to kde-i18n-doc is also 
important to notify the other translation teams for them not to miss the update.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  revert-force-stripes-string-change (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24534

To: filipf, #plasma, #vdg, aspotashev, ngraham
Cc: jriddell, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-16 Thread Nathaniel Graham 
ngraham added a comment.


  @aspotashev is a translator and he's approved, so I'd say you're good to go.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  revert-force-stripes-string-change (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24534

To: filipf, #plasma, #vdg, aspotashev, ngraham
Cc: jriddell, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-16 Thread Filip Fila 
filipf added a comment.


  Do we have a green light for 5.17.1? How do I tag the translators?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  revert-force-stripes-string-change (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24534

To: filipf, #plasma, #vdg, aspotashev, ngraham
Cc: jriddell, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Alexander Potashev 
aspotashev added a comment.


  In D24534#544785 , @davidedmundson 
wrote:
  
  > Original commit: https://git.reviewboard.kde.org/r/123738/
  >
  > (following it through quite a few renames)
  >
  > From what I can tell, it's akin to the direction property in a Flow
  
  
  I guess "Always arrange tasks in columns of as many rows" was meant to be 
"Always arrange tasks in columns of as many rows as possible". However this 
still sounds complicated.
  
  Plasma folder view has a similar algorithm for arranging icons (either 
top-to-bottom or left-to-right), here is how to access it in the UI:
  F7568144: Screenshot_20191010_204215.png 
, may be reasonable to reuse this wording 
"Arrange in ... Rows/Columns".

REPOSITORY
  R119 Plasma Desktop

BRANCH
  revert-force-stripes-string-change (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24534

To: filipf, #plasma, #vdg, aspotashev, ngraham
Cc: jriddell, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Nathaniel Graham 
ngraham added a subscriber: jriddell.
ngraham added a comment.


  FWIW Plasma 5.17 tars were already made so if we want this in Plasma 5.17.0, 
in addition to landing it on the stable branch, @jriddell will have to do some 
release magic to include it and you'll want to ping him about that.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  revert-force-stripes-string-change (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24534

To: filipf, #plasma, #vdg, aspotashev, ngraham
Cc: jriddell, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Alexander Potashev 
aspotashev accepted this revision.
aspotashev added a comment.


  The changes in messages are indeed reverted by this patch.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  revert-force-stripes-string-change (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24534

To: filipf, #plasma, #vdg, aspotashev, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Nathaniel Graham 
ngraham added a comment.


  Idea for a better string: "Fill each row/column before adding tasks to the 
next row/column"

REPOSITORY
  R119 Plasma Desktop

BRANCH
  revert-force-stripes-string-change (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24534

To: filipf, #plasma, #vdg, aspotashev, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks David, that's very helpful. Let's revert this in Plasma 5.17 for now 
(if translators approve) and work on a better string (or even a better UI) for 
Plasma 5.18.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  revert-force-stripes-string-change (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24534

To: filipf, #plasma, #vdg, aspotashev, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread David Edmundson 
davidedmundson added a comment.


  Original commit: https://git.reviewboard.kde.org/r/123738/
  
  (following it through quite a few renames)
  
  From what I can tell, it's akin to the direction property in a Flow

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24534

To: filipf, #plasma, #vdg, aspotashev
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Nathaniel Graham 
ngraham added a comment.


  After playing around with this option with my IOTM at various panel widths 
and various "maximum rows/columns" values, I still cannot for the life of me 
figure out what on earth it does--or else the feature is so buggy I'm unable to 
discover the pattern.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24534

To: filipf, #plasma, #vdg, aspotashev
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Filip Fila 
filipf added a comment.


  In D24534#544703 , @ngraham wrote:
  
  > "rows of as many columns"
  >
  > I'm afraid I still have no idea what this means! :) Can you explain what it 
actually does? Then maybe we can come up with a clear string together.
  
  
  Yeah that was me as well when I made the string change :)
  
  F7566788: image.png 
  
  But I think(?) I understand now. I think it says "look, you've defined the 
maximum no. of rows/columns, do you want me to arrange tasks in as many 
columns/rows as you've just defined".
  
  I can't quite come up with something that doesn't sound clunky, but IMO we 
don't need the "always".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24534

To: filipf, #plasma, #vdg, aspotashev
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Nathaniel Graham 
ngraham added a comment.


  "rows of as many columns"
  
  I'm afraid I still have no idea what this means! :) Can you explain what it 
actually does? Then maybe we can come up with a clear string together.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24534

To: filipf, #plasma, #vdg, aspotashev
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Filip Fila 
filipf added a subscriber: ngraham.
filipf added a comment.


  I still think the string could be improved some, maybe @ngraham has an idea.
  
  But the question is can this land in 5.17 given it's a string change? (albeit 
just a revert)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24534

To: filipf, #plasma, #vdg, aspotashev
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

2019-10-10 Thread Filip Fila 
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  I changed the "forceStripes" checkbox string in D19280 
, most likey because I thought it wasn't 
super understandable.
  
  The new string I pushed doesn't, however, match what the option does.
  
  So reverting the change.
  
  BUG: 412801

REPOSITORY
  R119 Plasma Desktop

BRANCH
  revert-force-stripes-string-change (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24534

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ConfigAppearance.qml

To: filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart