D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

[Roman Gilg]

romangg added a comment.


  @miraiko Do you have an email address that should be used for the commit?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24711

To: miraiko, #plasma, romangg
Cc: anthonyfieroni, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

[Mirai Komachi]

miraiko updated this revision to Diff 68109.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24711?vs=68084=68109

REVISION DETAIL
  https://phabricator.kde.org/D24711

AFFECTED FILES
  kcms/mouse/backends/x11/x11_libinput_dummydevice.cpp

To: miraiko, #plasma, romangg
Cc: anthonyfieroni, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

[Mirai Komachi]

miraiko added a comment.


  In D24711#548705 , @anthonyfieroni 
wrote:
  
  > 
https://phabricator.kde.org/source/plasma-desktop/browse/master/kcms/mouse/backends/x11/x11_libinput_dummydevice.cpp$126
  >  It should be changed also, right?
  
  
  I don't think so, there is no problem with qreal values.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24711

To: miraiko, #plasma, romangg
Cc: anthonyfieroni, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

[Anthony Fieroni]

anthonyfieroni added a comment.


  
https://phabricator.kde.org/source/plasma-desktop/browse/master/kcms/mouse/backends/x11/x11_libinput_dummydevice.cpp$126
  It should be changed also, right?
  When you create a diff add a more context to it, like `git diff -U100 > patch`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24711

To: miraiko, #plasma, romangg
Cc: anthonyfieroni, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

[Mirai Komachi]

miraiko added a comment.


  Thank you for the review.
  
  In D24711#548523 , @ngraham wrote:
  
  > Did this change recently?
  
  
  According to xf86-input-libinput git, this has been since 2015.
  
https://cgit.freedesktop.org/xorg/driver/xf86-input-libinput/commit/?id=0163482e22ad65ec51e3636cf31f9f39e29ff709
  "Now" is a superfluous word here.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24711

To: miraiko, #plasma, romangg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

[Nathaniel Graham]

ngraham added a comment.


  Thanks for submitting this patch!
  
  What exactly do you mean by "now"? Did this change recently?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24711

To: miraiko, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

[Mirai Komachi]

miraiko created this revision.
miraiko added a reviewer: Plasma.
miraiko added a project: Plasma.
miraiko requested review of this revision.

REVISION SUMMARY
  LIBINPUT_PROP_ACCEL_PROFILE_ENABLED now contains two values, 
valueWriterPart function didn't handle it correctly.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24711

AFFECTED FILES
  kcms/mouse/backends/x11/x11_libinput_dummydevice.cpp

To: miraiko, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart