D24758: [KEditFileType] Add a desktop file

2019-10-18 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R126:9b2c7dec61de: [KEditFileType] Add a desktop file 
(authored by meven).

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24758?vs=68243&id=68245

REVISION DETAIL
  https://phabricator.kde.org/D24758

AFFECTED FILES
  keditfiletype/CMakeLists.txt
  keditfiletype/org.kde.keditfiletype.desktop

To: meven, broulik, ngraham
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24758: [KEditFileType] Add a desktop file

2019-10-18 Thread Friedrich W. H. Kossebau 
kossebau added inline comments.

INLINE COMMENTS

> meven wrote in CMakeLists.txt:57
> We have a bunch of apps to update, I used this because I found it in krusader 
> code

Yes, due to having no proper cmake deprecation warnings there are still some 
with old code. But lots of porting already happened :)

Perhaps KDE_INSTALL_DIRS_NO_DEPRECATED should be started to be enforced on CI :)

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24758

To: meven, broulik, ngraham
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24758: [KEditFileType] Add a desktop file

2019-10-18 Thread Méven Car 
meven added inline comments.

INLINE COMMENTS

> kossebau wrote in CMakeLists.txt:57
> KDE_INSTALL_APPDIR, please. XDG_APPS_INSTALL_DIR is deprecated, cmp. 
> https://api.kde.org/ecm/kde-module/KDEInstallDirs.html

We have a bunch of apps to update, I used this because I found it in krusader 
code

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24758

To: meven, broulik, ngraham
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24758: [KEditFileType] Add a desktop file

2019-10-18 Thread Méven Car 
meven marked an inline comment as done.
meven added a comment.


  Thanks @kossebau @broulik

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D24758

To: meven, broulik, ngraham
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24758: [KEditFileType] Add a desktop file

2019-10-18 Thread Méven Car 
meven updated this revision to Diff 68243.
meven added a comment.


  Replace OnlyShowIn= by NoDisplay=true USe KDE_INSTALL_APPDIR instead of 
deprecated XDG_APPS_INSTALL_DIR

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24758?vs=68239&id=68243

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24758

AFFECTED FILES
  keditfiletype/CMakeLists.txt
  keditfiletype/org.kde.keditfiletype.desktop

To: meven, broulik, ngraham
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24758: [KEditFileType] Add a desktop file

2019-10-18 Thread Friedrich W. H. Kossebau 
kossebau added inline comments.

INLINE COMMENTS

> CMakeLists.txt:57
>  install( FILES filetypes.desktop  DESTINATION  ${KDE_INSTALL_KSERVICES5DIR} )
> +install(PROGRAMS org.kde.keditfiletype.desktop DESTINATION 
> ${XDG_APPS_INSTALL_DIR} )

KDE_INSTALL_APPDIR, please. XDG_APPS_INSTALL_DIR is deprecated, cmp. 
https://api.kde.org/ecm/kde-module/KDEInstallDirs.html

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D24758

To: meven, broulik, ngraham
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24758: [KEditFileType] Add a desktop file

2019-10-18 Thread Kai Uwe Broulik 
broulik added a comment.


  Should this be `NoDisplay` since you can't just launch it without an argument

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D24758

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart