D24848: fix kcm fonts "typo" on connect

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:08a8914d7169: fix kcm fonts typo on connect 
(authored by bport, committed by ervin).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24848?vs=68500=69094

REVISION DETAIL
  https://phabricator.kde.org/D24848

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: bport, #plasma, mart, ervin, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24848: fix kcm fonts "typo" on connect

[Kevin Ottens]

ervin accepted this revision.
ervin added a comment.


  In D24848#551863 , @broulik wrote:
  
  > Interesting, I thought Qt would/could static_assert that
  
  
  Well, it turns out the signatures were compatible in fact (getters connected 
to a function which takes no parameter, signatures are fine). But since it is 
done by the C++ compiler, this one has no idea if the second parameter of the 
connect is indeed a signal (this is a completely alien concept to it). This is 
the one blind spot of the new style connects.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24848

To: bport, #plasma, mart, ervin, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24848: fix kcm fonts "typo" on connect

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Interesting, I thought Qt would/could static_assert that

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24848

To: bport, #plasma, mart, ervin, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24848: fix kcm fonts "typo" on connect

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, mart, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REVISION SUMMARY
  connect was not done correctly

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24848

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: bport, #plasma, mart, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart