D24853: [DigitalClock] Fix layout and QML warnings

2019-10-25 Thread Konrad Materka 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:82cfabd0a5c8: [DigitalClock] Fix layout and QML warnings 
(authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24853?vs=68743=68745

REVISION DETAIL
  https://phabricator.kde.org/D24853

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configAppearance.qml
  applets/digital-clock/package/contents/ui/configTimeZones.qml

To: kmaterka, #plasma, #plasma_workspaces, ngraham
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-25 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24853

To: kmaterka, #plasma, #plasma_workspaces, ngraham
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-25 Thread Konrad Materka 
kmaterka updated this revision to Diff 68743.
kmaterka added a comment.


  Remove hardcoded margins, these are not needed anymore.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24853?vs=68524=68743

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24853

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configAppearance.qml
  applets/digital-clock/package/contents/ui/configTimeZones.qml

To: kmaterka, #plasma, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-25 Thread Konrad Materka 
kmaterka added inline comments.

INLINE COMMENTS

> ngraham wrote in configTimeZones.qml:58
> Don't use hardcoded margins. This should be `Kirigami.Units.smallSpacing`

I just copied values form the original Rectangle. I will remove it entirely, 
probably it's not needed anymore.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24853

To: kmaterka, #plasma, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-24 Thread Nathaniel Graham 
ngraham added a comment.


  Fair enough, that seems reasonable.

INLINE COMMENTS

> configTimeZones.qml:58
> +Layout.fillWidth: true
> +Layout.margins: 1
>  

Don't use hardcoded margins. This should be `Kirigami.Units.smallSpacing`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24853

To: kmaterka, #plasma, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-24 Thread Konrad Materka 
kmaterka added a comment.


  It looks like there are some review changes required in D24798 
. Maybe I can commit my changes first? 
D24798  needs changes anyway and it would 
be good to split QCC1 -> QCC2 migration from layout fix.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24853

To: kmaterka, #plasma, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-22 Thread Konrad Materka 
kmaterka marked 3 inline comments as done.
kmaterka added a comment.


  In D24853#552228 , @ngraham wrote:
  
  > Some of this partially conflicts with D24798 
 FWIW.
  
  
  I can wait and rebase later - your decision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24853

To: kmaterka, #plasma, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-22 Thread Nathaniel Graham 
ngraham added a comment.


  Some of this partially conflicts with D24798 
 FWIW.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24853

To: kmaterka, #plasma, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-22 Thread Konrad Materka 
kmaterka updated this revision to Diff 68524.
kmaterka marked 3 inline comments as done.
kmaterka added a comment.


  Review changes: Kirigami component, removed anchors

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24853?vs=68512=68524

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24853

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configAppearance.qml
  applets/digital-clock/package/contents/ui/configTimeZones.qml

To: kmaterka, #plasma, #plasma_workspaces
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-22 Thread Konrad Materka 
kmaterka marked 3 inline comments as done.
kmaterka added inline comments.

INLINE COMMENTS

> davidedmundson wrote in configTimeZones.qml:32
> Do you need these?
> 
> Generally it's a sign of a problem or bad layering if the root item has 
> anchors in it.

Ops, copy from HolidayConfig.qml. I'll remove it, width/height are not 
needed, I just checked, AppletConfiguration.qml handles that.

> davidedmundson wrote in configTimeZones.qml:56
> If we're going to port stuff, we may as well port to:
> 
> https://api.kde.org/frameworks/kirigami/html/classorg_1_1kde_1_1kirigami_1_1InlineMessage.html
> 
> the library version of this

Cool! I need there must be something!

> davidedmundson wrote in configTimeZones.qml:96
> What's this for? Opacity should be inherited by children

I will use Kirigami component.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24853

To: kmaterka, #plasma, #plasma_workspaces
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-22 Thread David Edmundson 
davidedmundson added a comment.


  Concept +1, I love layouts

INLINE COMMENTS

> configTimeZones.qml:32
>  id: timeZonesPage
> -width: parent.width
> -height: parent.height
> +anchors.left: parent.left
> +anchors.right: parent.right

Do you need these?

Generally it's a sign of a problem or bad layering if the root item has anchors 
in it.

> configTimeZones.qml:56
>  
> +Rectangle {
> +id: messageWidget

If we're going to port stuff, we may as well port to:

https://api.kde.org/frameworks/kirigami/html/classorg_1_1kde_1_1kirigami_1_1InlineMessage.html

the library version of this

> configTimeZones.qml:96
> +source: "dialog-warning"
> +opacity: messageWidget.opacity
>  }

What's this for? Opacity should be inherited by children

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24853

To: kmaterka, #plasma, #plasma_workspaces
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24853: [DigitalClock] Fix layout and QML warnings

2019-10-22 Thread Konrad Materka 
kmaterka created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  Fixed issue when time zone configuration page was not scaling corrently. As a 
result two
  srollbars were rendered.
  Fixed few QML layout warnings and undefined references.

TEST PLAN
  Open Time zones configuration page and shrink window - two scrollbars are 
rendered.
  Expected: table is scalled correctly and only one scrollbar in table is 
rendered.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24853

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configAppearance.qml
  applets/digital-clock/package/contents/ui/configTimeZones.qml

To: kmaterka
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart