D25198: KCM Colors : port color scheme state management to KConfigXT

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:199bbe20d72c: KCM Colors : port color scheme state 
management to KConfigXT (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25198?vs=69401=69668

REVISION DETAIL
  https://phabricator.kde.org/D25198

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/colorssettings.kcfg
  kcms/colors/colorssettings.kcfgc

To: crossi, #plasma, ervin, mart, bport
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25198: KCM Colors : port color scheme state management to KConfigXT

[Cyril Rossi]

crossi added a comment.


  In D25198#559853 , @broulik wrote:
  
  > Note that the KCM also writes all of the colors into kdeglobals (for 
whatever reason) - does this also need to be ported? We don't read those colors 
in the KCM anymore, just write them out when applying, so maybe not.
  
  
  Thanks for your comment.
  
  I noticed that, since it's a copy from color-scheme to kdeglobals, I thought 
it was not part of the kcm's state to be managed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25198

To: crossi, #plasma, ervin, mart, bport
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25198: KCM Colors : port color scheme state management to KConfigXT

[Kevin Ottens]

ervin added a comment.


  In D25198#559853 , @broulik wrote:
  
  > Note that the KCM also writes all of the colors into kdeglobals (for 
whatever reason) - does this also need to be ported? We don't read those colors 
in the KCM anymore, just write them out when applying, so maybe not.
  
  
  I assumed the styles were reading them... but maybe that's to be confirmed 
indeed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25198

To: crossi, #plasma, ervin, mart, bport
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25198: KCM Colors : port color scheme state management to KConfigXT

[Kai Uwe Broulik]

broulik added a comment.


  Note that the KCM also writes all of the colors into kdeglobals (for whatever 
reason) - does this also need to be ported? We don't read those colors in the 
KCM anymore, just write them out when applying, so maybe not.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25198

To: crossi, #plasma, ervin, mart, bport
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25198: KCM Colors : port color scheme state management to KConfigXT

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, mart, bport.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25198

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/colorssettings.kcfg
  kcms/colors/colorssettings.kcfgc

To: crossi, #plasma, ervin, mart, bport
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart