D25488: kwayland-integration: fix compilation with no-deprecated build of kwindowsystem
dfaure added a comment. Thanks for the idea, done in https://commits.kde.org/kwayland-integration/3ce73d56ca5364242be3eb7cb1b5c4f5eaf47196 REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D25488 To: dfaure, kossebau, jriddell, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25488: kwayland-integration: fix compilation with no-deprecated build of kwindowsystem
dfaure closed this revision. REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D25488 To: dfaure, kossebau, jriddell, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25488: kwayland-integration: fix compilation with no-deprecated build of kwindowsystem
kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. For a backport, one could perhaps do this after the includes: #fndef KWINDOWSYSTEM_BUILD_DEPRECATED_SINCE #ifndef KWINDOWSYSTEM_NO_DEPRECATED #define KWINDOWSYSTEM_BUILD_DEPRECATED_SINCE(x, y) 1 #else #define KWINDOWSYSTEM_BUILD_DEPRECATED_SINCE(x, y) 0 #endif #endif Otherwise seems fine with me from pure patch reading. REPOSITORY R130 Frameworks integration plugin using KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D25488 To: dfaure, kossebau, jriddell, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25488: kwayland-integration: fix compilation with no-deprecated build of kwindowsystem
dfaure created this revision. dfaure added reviewers: kossebau, jriddell, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. REVISION SUMMARY I build kwindowsystem with -DEXCLUDE_DEPRECATED_BEFORE_AND_AT=5.62.0, and this broke here. Use the exact same condition as the one around those virtual methods in the base class. This required upgrading the KF5 requirement from 5.62 to 5.64, so no backport to Plasma/5.17 unfortunately. REPOSITORY R130 Frameworks integration plugin using KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D25488 AFFECTED FILES CMakeLists.txt src/windowsystem/windowsystem.cpp src/windowsystem/windowsystem.h To: dfaure, kossebau, jriddell, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
