gikari created this revision.
gikari added a reviewer: apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.
REVISION SUMMARY
This diff introduces purely cosmetic changes.
1. KCM now compiled with no signals/slot keywords to avoid clash with gtk
2. Remove linking of XCursors library, because it is no longer needed
3. Replace some for-cycles with range-based ones
4. Wrap some string literals with QStringLiteral
5. Rearrange include headers
6. Some other changes to better match code style
TEST PLAN
Check, if there is no regressions
REPOSITORY
R99 KDE Gtk Configuration Tool
BRANCH
refactor-kcm-code (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25872
AFFECTED FILES
CMakeLists.txt
src/abstractappearance.cpp
src/abstractappearance.h
src/appearancegtk2.cpp
src/appearancegtk2.h
src/appearancegtk3.cpp
src/appearancegtk3.h
src/appearencegtk.cpp
src/appearencegtk.h
src/dialog_installer.cpp
src/dialog_installer.h
src/dialog_uninstaller.cpp
src/dialog_uninstaller.h
src/gtkconfigkcmodule.cpp
src/gtkconfigkcmodule.h
src/installer.cpp
src/thread.cpp
src/thread.h
tests/CMakeLists.txt
tests/configsavetest.h
To: gikari, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
