D25886: Add support for sub-comments to the Reviews backend
This revision was automatically updated to reflect the committed changes. Closed by commit R134:a4b6d2d5c25e: Add support for sub-comments to the Reviews backend (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25886?vs=71277=71286 REVISION DETAIL https://phabricator.kde.org/D25886 AFFECTED FILES discover/qml/ReviewDelegate.qml libdiscover/ReviewsBackend/ReviewsModel.cpp libdiscover/ReviewsBackend/ReviewsModel.h libdiscover/backends/KNSBackend/KNSReviews.cpp To: leinir, #discover_software_store, #plasma, apol, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25886: Add support for sub-comments to the Reviews backend
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice! REPOSITORY R134 Discover Software Store BRANCH add-support-for-subcomments (branched from master) REVISION DETAIL https://phabricator.kde.org/D25886 To: leinir, #discover_software_store, #plasma, apol, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25886: Add support for sub-comments to the Reviews backend
leinir created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Using a similar style to the comments delegate in KNewStuffQuick, this adds the functionality for having subcomments in the Reviews model. The end result is that we no longer have incorrect numbers showing in Discover, as it now shows all the items returned by the server. - Adds a role for the depth of reviews (used for comments on reviews) - Adds sub-comments (and set their depth) in the KNS backend's reviews - Adapts the ReviewDelegate to have indentation marks (styled like KNSQuick) REPOSITORY R134 Discover Software Store BRANCH add-support-for-subcomments (branched from master) REVISION DETAIL https://phabricator.kde.org/D25886 AFFECTED FILES discover/qml/ReviewDelegate.qml libdiscover/ReviewsBackend/ReviewsModel.cpp libdiscover/ReviewsBackend/ReviewsModel.h libdiscover/backends/KNSBackend/KNSReviews.cpp To: leinir Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
