D25935: [Notifications] Add hint for showing a notification even in do not disturb mode
broulik added a comment. It was suggested to make it more semantic, i.e. be about "this is feedback for user-initiated task" which will then imply showing in dnd mode. Suggestions on how to phrase that as a key name? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25935 To: broulik, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25935: [Notifications] Add hint for showing a notification even in do not disturb mode
ngraham added a comment. All right, you've convinced me. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25935 To: broulik, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25935: [Notifications] Add hint for showing a notification even in do not disturb mode
broulik added a comment. How is it, though? It is an internal hint on some DBus method no user will ever see. Internally it's all things like notificationsInhibitedUntil, even the (public) DBus API says "Inhibited" REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25935 To: broulik, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25935: [Notifications] Add hint for showing a notification even in do not disturb mode
ngraham added a comment. Yeah but this is a user-facing thing (well, sort of user-facing). Eh, your choice. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25935 To: broulik, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25935: [Notifications] Add hint for showing a notification even in do not disturb mode
broulik added a comment. Internally it uses "inhibited" for that everywhere REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25935 To: broulik, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25935: [Notifications] Add hint for showing a notification even in do not disturb mode
ngraham added a comment. `x-kde-show-when-in-do-not-disturb-mode` maybe? Might be nice to reference the feature itself in the keyword since "inhibited" is rather vague. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25935 To: broulik, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25935: [Notifications] Add hint for showing a notification even in do not disturb mode
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This can be useful for notifications that confirm direct user interaction, such as successful Bluetooth pairing, Screenshot creation, or plasmoid removal. It only overrules filtering based on urgency, disabling notifications for that application altogether will still hide them. TEST PLAN Enabled dnd mode, `notify-send foo bar -h string:x-kde-show-when-inhibited:true` and it showed up regardless REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25935 AFFECTED FILES libnotificationmanager/notification.cpp libnotificationmanager/notification.h libnotificationmanager/notification_p.h libnotificationmanager/notificationfilterproxymodel.cpp libnotificationmanager/notifications.h libnotificationmanager/notificationsmodel.cpp To: broulik, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
