D26086: Don't fetch pixmap if we have it already

2020-01-05 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:08f02266c922: Dont fetch pixmap if we have it 
already (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26086?vs=71794=72785

REVISION DETAIL
  https://phabricator.kde.org/D26086

AFFECTED FILES
  libtaskmanager/xwindowtasksmodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26086: Don't fetch pixmap if we have it already

2019-12-18 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `AppData` contains a `QIcon` with pixmap data gathered from 
`KWindowSystem::icon` which we can just use.
  Only if, for some reason, the icon is really null, try getting it from 
`KWindowSystem` on demand.

TEST PLAN
  Pinned my xcalc to the task bar, got the same pixmap serialized as before, 
without a roundtrip to the x server

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26086

AFFECTED FILES
  libtaskmanager/xwindowtasksmodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart