D26124: Add byte display option in Network Monitor plasmoid

2019-12-21 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d21cb2e7a95b: Add byte display option in Network Monitor 
plasmoid (authored by gvgeo, committed by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26124?vs=71926=71961

REVISION DETAIL
  https://phabricator.kde.org/D26124

AFFECTED FILES
  applets/systemmonitor/common/contents/config/main.xml
  applets/systemmonitor/net/contents/config/config.qml
  applets/systemmonitor/net/contents/ui/displayConfig.qml
  applets/systemmonitor/net/contents/ui/net.qml

To: gvgeo, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26124: Add byte display option in Network Monitor plasmoid

2019-12-21 Thread Nathaniel Graham 
ngraham added a comment.


  Lovely contribution, thanks very much!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26124

To: gvgeo, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26124: Add byte display option in Network Monitor plasmoid

2019-12-21 Thread George Vogiatzis 
gvgeo updated this revision to Diff 71926.
gvgeo added a comment.


  Correct label of displayUnits in xml.
  Add values to displayUints options.
  Correct copyright message.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26124?vs=71921=71926

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26124

AFFECTED FILES
  applets/systemmonitor/common/contents/config/main.xml
  applets/systemmonitor/net/contents/config/config.qml
  applets/systemmonitor/net/contents/ui/displayConfig.qml
  applets/systemmonitor/net/contents/ui/net.qml

To: gvgeo, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26124: Add byte display option in Network Monitor plasmoid

2019-12-20 Thread Nathaniel Graham 
ngraham added a comment.


  Even nicer. :)

INLINE COMMENTS

> main.xml:22
> +
> +1
> +

an inline comment documenting what the ints map to would be nice

> displayConfig.qml:2
> +/*
> + *   Copyright 2015 Marco Martin 
> + *

Your copyright

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26124

To: gvgeo, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26124: Add byte display option in Network Monitor plasmoid

2019-12-20 Thread George Vogiatzis 
gvgeo updated this revision to Diff 71921.
gvgeo added a comment.


  Add xml display entry, to save the option.
  Added in the common main.xml. Now the rest 4 system monitor applets 
  will have an extra entry that will not use.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26124?vs=71902=71921

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26124

AFFECTED FILES
  applets/systemmonitor/common/contents/config/main.xml
  applets/systemmonitor/net/contents/config/config.qml
  applets/systemmonitor/net/contents/ui/displayConfig.qml
  applets/systemmonitor/net/contents/ui/net.qml

To: gvgeo, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26124: Add byte display option in Network Monitor plasmoid

2019-12-20 Thread Nathaniel Graham 
ngraham accepted this revision as: VDG.
ngraham added a reviewer: Plasma.
ngraham added a comment.


  Nice clean QML and a reasonable UI.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26124

To: gvgeo, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26124: Add byte display option in Network Monitor plasmoid

2019-12-20 Thread George Vogiatzis 
gvgeo added a comment.


  I can't find  a way to add the new option in the same Interfaces group.
  If I add Kirigami.FormLayout stops reading the values, even if the layout 
works.
  Tried something like this:
  
Kirigami.FormLayout {  //

D26124: Add byte display option in Network Monitor plasmoid

2019-12-20 Thread George Vogiatzis 
gvgeo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Add the option to select between byte and bit display in Network Monitor 
plasmoid.
  Bug: 383019

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26124

AFFECTED FILES
  applets/systemmonitor/net/contents/config/config.qml
  applets/systemmonitor/net/contents/ui/displayConfig.qml
  applets/systemmonitor/net/contents/ui/net.qml

To: gvgeo
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart