D26228: KCM Fonts ConfigModule to ManagedConfigModule

2019-12-31 Thread Benjamin Port 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:11092af79680: KCM Fonts ConfigModule to 
ManagedConfigModule (authored by bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26228?vs=72450=72451

REVISION DETAIL
  https://phabricator.kde.org/D26228

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: bport, #plasma, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26228: KCM Fonts ConfigModule to ManagedConfigModule

2019-12-31 Thread Benjamin Port 
bport updated this revision to Diff 72450.
bport added a comment.


  Fix coding style

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26228?vs=72195=72450

REVISION DETAIL
  https://phabricator.kde.org/D26228

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: bport, #plasma, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26228: KCM Fonts ConfigModule to ManagedConfigModule

2019-12-26 Thread Kevin Ottens 
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> fonts.cpp:600
>  
> -void KFonts::updateNeedsSave()
> -{
> -setNeedsSave(m_settings->isSaveNeeded() || 
> m_fontAASettings->needsSave());
> +bool KFonts::isSaveNeeded() const {
> +return m_fontAASettings->needsSave();

{ should be on its own line

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26228

To: bport, #plasma, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26228: KCM Fonts ConfigModule to ManagedConfigModule

2019-12-26 Thread Benjamin Port 
bport created this revision.
bport added reviewers: Plasma, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26228

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: bport, #plasma, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart