D26256: [Applet] Make 'raise maximum volume' global
This revision was automatically updated to reflect the committed changes. Closed by commit R115:d0c753c188e8: [Applet] Make raise maximum volume global (authored by gvgeo, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26256?vs=74192=74798 REVISION DETAIL https://phabricator.kde.org/D26256 AFFECTED FILES applet/contents/code/icon.js applet/contents/config/main.xml applet/contents/ui/ConfigGeneral.qml applet/contents/ui/ListItemBase.qml applet/contents/ui/main.qml To: gvgeo, ngraham, #vdg, #plasma, drosca Cc: drosca, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26256: [Applet] Make 'raise maximum volume' global
gvgeo updated this revision to Diff 74192. gvgeo added a comment. Fix volume icons REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26256?vs=74146=74192 BRANCH raise2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26256 AFFECTED FILES applet/contents/code/icon.js applet/contents/config/main.xml applet/contents/ui/ConfigGeneral.qml applet/contents/ui/ListItemBase.qml applet/contents/ui/main.qml To: gvgeo, ngraham, #vdg, #plasma, drosca Cc: drosca, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26256: [Applet] Make 'raise maximum volume' global
gvgeo updated this revision to Diff 74146. gvgeo added a comment. rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26256?vs=73920=74146 BRANCH raise2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26256 AFFECTED FILES applet/contents/config/main.xml applet/contents/ui/ConfigGeneral.qml applet/contents/ui/ListItemBase.qml applet/contents/ui/main.qml To: gvgeo, ngraham, #vdg, #plasma, drosca Cc: drosca, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26256: [Applet] Make 'raise maximum volume' global
gvgeo updated this revision to Diff 73920. gvgeo added a comment. Raise maximum volume has the potential to aid in speaker blowout. Although this requires a system not properly configured (an amplifier too powerful with no limiter). I expect this to be the case only with DIY audio setups. I know that in theory it should be safe, and can only create distortions. And damage to speaker can happen with a very high sound, without raise functionality. Despite this I feel this option has no place to be so accessible in the applet(calling, for example, kids to try the 'Boost' button). Because time has been already invested in these patches, the only change I made was disabling the checkbox. That way, YOU can easily enable it. Sorry for the inconvenience, so late too. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26256?vs=73239=73920 BRANCH raise2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26256 AFFECTED FILES applet/contents/config/main.xml applet/contents/ui/ConfigGeneral.qml applet/contents/ui/ListItemBase.qml applet/contents/ui/main.qml To: gvgeo, ngraham, #vdg, #plasma, drosca Cc: drosca, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26256: [Applet] Make 'raise maximum volume' global
gvgeo updated this revision to Diff 73239. gvgeo added a comment. rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26256?vs=72915=73239 BRANCH raise (branched from master) REVISION DETAIL https://phabricator.kde.org/D26256 AFFECTED FILES applet/contents/config/main.xml applet/contents/ui/ConfigGeneral.qml applet/contents/ui/ListItemBase.qml applet/contents/ui/main.qml To: gvgeo, ngraham, #vdg, #plasma, drosca Cc: drosca, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26256: [Applet] Make 'raise maximum volume' global
gvgeo updated this revision to Diff 72915. gvgeo added a comment. rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26256?vs=72855=72915 BRANCH raise (branched from master) REVISION DETAIL https://phabricator.kde.org/D26256 AFFECTED FILES applet/contents/config/main.xml applet/contents/ui/ConfigGeneral.qml applet/contents/ui/ListItemBase.qml applet/contents/ui/main.qml To: gvgeo, ngraham, #vdg, #plasma, drosca Cc: drosca, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26256: [Applet] Make 'raise maximum volume' global
gvgeo updated this revision to Diff 72855. gvgeo added a comment. rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26256?vs=72751=72855 BRANCH raise (branched from master) REVISION DETAIL https://phabricator.kde.org/D26256 AFFECTED FILES applet/contents/config/main.xml applet/contents/ui/ConfigGeneral.qml applet/contents/ui/ListItemBase.qml applet/contents/ui/main.qml To: gvgeo, ngraham, #vdg, #plasma, drosca Cc: drosca, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26256: [Applet] Make 'raise maximum volume' global
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
Works great. Just a few code change requests:
INLINE COMMENTS
> main.qml:546
> +id: raiseMaximumVolumeCheckbox
> +spacing: units.smallSpacing * 1.5
> +Layout.leftMargin: units.smallSpacing * 0.75 + 4
Don't override this; if it looks bad with the default value, we should fix that
in the checkbox control itself
> main.qml:547
> +spacing: units.smallSpacing * 1.5
> +Layout.leftMargin: units.smallSpacing * 0.75 + 4
> +checked: plasmoid.configuration.raiseMaximumVolume
This could evaluate to a fractional number. You probably want
`units.largeSpacing` here (the spacing doesn't have to be //literally//
identical to the mockup; it's more important to use standard spacing values)
> main.qml:549
> +checked: plasmoid.configuration.raiseMaximumVolume
> +onCheckedChanged: {
> +plasmoid.configuration.raiseMaximumVolume = checked
Always use `onToggled` to handle user input, never `onCheckedChanged`
If you're deliberately using `onCheckedChanged` because it has the side effect
of evaluating the logic in here when the applet is first loaded, then don't do
that, and instead explicitly call that logic in an `onCompleted` block
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D26256
To: gvgeo, ngraham, #vdg, #plasma, drosca
Cc: drosca, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26256: [Applet] Make 'raise maximum volume' global
gvgeo updated this revision to Diff 72751. gvgeo added a comment. squash REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26256?vs=72740=72751 BRANCH raise (branched from master) REVISION DETAIL https://phabricator.kde.org/D26256 AFFECTED FILES applet/contents/config/main.xml applet/contents/ui/ConfigGeneral.qml applet/contents/ui/ListItemBase.qml applet/contents/ui/main.qml To: gvgeo, ngraham, #vdg, #plasma, drosca Cc: drosca, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
