D26266: Change remove action's icon to "edit-delete"

[Tranter Madi]

trmdi abandoned this revision.
trmdi added a comment.


  In D26266#584135 , @mvourlakos 
wrote:
  
  > What is ConfigOverlay for plasma panels is using at its tooltip?
  
  
  Ah, I was wrong. "delete" should be the right one. Sorry.
  
https://github.com/KDE/plasma-desktop/blob/def96d60241ad7c835532ee09bf95afb7f56fed7/containments/panel/contents/ui/ConfigOverlay.qml#L408

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26266

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26266: Change remove action's icon to "edit-delete"

[Michail Vourlakos]

mvourlakos added a comment.


  What is ConfigOverlay for plasma panels is using at its tooltip?

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26266

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26266: Change remove action's icon to "edit-delete"

[Tranter Madi]

trmdi added a comment.


  But I've just found that Plasma panels use QIcon::fromTheme which load the 
icon from the icon theme, while PlasmaComponent.ToolButton loads icon from 
Plasma theme, that is not consistent in some cases. What do you think?

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26266

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26266: Change remove action's icon to "edit-delete"

[Tranter Madi]

trmdi created this revision.
trmdi added reviewers: Latte Dock, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  Follow Plasma codes
  
https://github.com/KDE/plasma-framework/blob/ccceb83b107213ba5d2077fc346d4ab8a027d049/src/plasma/private/applet_p.cpp#L386

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26266

AFFECTED FILES
  containment/package/contents/ui/editmode/ConfigOverlay.qml
  shell/package/contents/configuration/LatteDockConfiguration.qml

To: trmdi, #latte_dock, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart