D26279: ActionToolBar: Only show the overflow button if there are visible items in the menu

2020-01-03 Thread Arjen Hiemstra 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:8c09cfd92dbf: ActionToolBar: Only show the overflow 
button if there are visible items in the… (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26279?vs=72344=72672

REVISION DETAIL
  https://phabricator.kde.org/D26279

AFFECTED FILES
  src/controls/ActionToolBar.qml

To: ahiemstra, #kirigami, ngraham, apol
Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart, hein

D26279: ActionToolBar: Only show the overflow button if there are visible items in the menu

2019-12-30 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.


  Thanks!

REPOSITORY
  R169 Kirigami

BRANCH
  actiontoolbar_contextbutton_visible

REVISION DETAIL
  https://phabricator.kde.org/D26279

To: ahiemstra, #kirigami, ngraham, apol
Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart, hein

D26279: ActionToolBar: Only show the overflow button if there are visible items in the menu

2019-12-29 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Fixes the issue, thanks!

REPOSITORY
  R169 Kirigami

BRANCH
  actiontoolbar_contextbutton_visible

REVISION DETAIL
  https://phabricator.kde.org/D26279

To: ahiemstra, #kirigami, ngraham
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart, hein

D26279: ActionToolBar: Only show the overflow button if there are visible items in the menu

2019-12-29 Thread Arjen Hiemstra 
ahiemstra updated this revision to Diff 72344.
ahiemstra added a comment.


  - Remove unrelated flat change

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26279?vs=72343=72344

BRANCH
  actiontoolbar_contextbutton_visible

REVISION DETAIL
  https://phabricator.kde.org/D26279

AFFECTED FILES
  src/controls/ActionToolBar.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26279: ActionToolBar: Only show the overflow button if there are visible items in the menu

2019-12-29 Thread Arjen Hiemstra 
ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This fixes https://bugs.kde.org/show_bug.cgi?id=415412 , which was occuring 
because the
  overflow button did not properly check to see if the actions in the menu were 
actually
  visible.
  
  BUG: 415412

TEST PLAN
  The example code from the linked bug report now works correctly.

REPOSITORY
  R169 Kirigami

BRANCH
  actiontoolbar_contextbutton_visible

REVISION DETAIL
  https://phabricator.kde.org/D26279

AFFECTED FILES
  src/controls/ActionToolBar.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein