D26386: Kicker/RecentDocuments: add icons to actions

2020-01-08 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4dca72bdf59a: Kicker/RecentDocuments: add icons to 
actions (authored by meven).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26386?vs=73035=73036

REVISION DETAIL
  https://phabricator.kde.org/D26386

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/kicker/plugin/actionlist.h
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/appsmodel.cpp
  applets/kicker/plugin/contactentry.cpp
  applets/kicker/plugin/recentcontactsmodel.cpp
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/rootmodel.cpp
  applets/kicker/plugin/runnermatchesmodel.cpp

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-08 Thread Méven Car 
meven updated this revision to Diff 73035.
meven added a comment.
This revision is now accepted and ready to land.


  Make icon non-optionnal in Kicker::createActionItem, add a missing icon

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26386?vs=72804=73035

BRANCH
  arcpatch-D26386_1

REVISION DETAIL
  https://phabricator.kde.org/D26386

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/kicker/plugin/actionlist.h
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/appsmodel.cpp
  applets/kicker/plugin/contactentry.cpp
  applets/kicker/plugin/recentcontactsmodel.cpp
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/rootmodel.cpp
  applets/kicker/plugin/runnermatchesmodel.cpp

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-07 Thread Eike Hein 
hein accepted this revision.
hein added a comment.


  Good stuff!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-07 Thread Méven Car 
meven planned changes to this revision.
meven added inline comments.

INLINE COMMENTS

> actionlist.cpp:62
>  
> +if (!icon.isEmpty()) {
> +map[QStringLiteral("icon")] = icon;

Remove this if

> recentcontactsmodel.cpp:93
>  
> -actionList << Kicker::createActionItem(i18n("Show Contact 
> Information..."), QStringLiteral("showContactInfo"));
> +actionList << Kicker::createActionItem(i18n("Show Contact 
> Information..."), QString(), QStringLiteral("showContactInfo"));
>  

Missing icon

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-06 Thread Méven Car 
meven added a comment.


  @hein is it fine for you ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-05 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  Nice!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-05 Thread Méven Car 
meven updated this revision to Diff 72804.
meven marked 2 inline comments as done.
meven added a comment.


  Add icon identity for showContactInfo action

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26386?vs=72755=72804

BRANCH
  arcpatch-D26386_1

REVISION DETAIL
  https://phabricator.kde.org/D26386

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/kicker/plugin/actionlist.h
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/appsmodel.cpp
  applets/kicker/plugin/contactentry.cpp
  applets/kicker/plugin/recentcontactsmodel.cpp
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/rootmodel.cpp
  applets/kicker/plugin/runnermatchesmodel.cpp

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-05 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> meven wrote in contactentry.cpp:117
> I missing an icon for this action, I am open for suggestion.

Maybe `user-identity` or `identity`, depending on what it does

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-05 Thread Méven Car 
meven added inline comments.

INLINE COMMENTS

> contactentry.cpp:117
>  
> -actionList << Kicker::createActionItem(i18n("Show Contact 
> Information..."), QStringLiteral("showContactInfo"));
> +actionList << Kicker::createActionItem(i18n("Show Contact 
> Information..."), QString(), QStringLiteral("showContactInfo"));
>  

I missing an icon for this action, I am open for suggestion.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-04 Thread Méven Car 
meven updated this revision to Diff 72755.
meven added a comment.


  Use view-hidden icon for Hide Application action for consistency

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26386?vs=72754=72755

BRANCH
  arcpatch-D26386_1

REVISION DETAIL
  https://phabricator.kde.org/D26386

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/kicker/plugin/actionlist.h
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/appsmodel.cpp
  applets/kicker/plugin/contactentry.cpp
  applets/kicker/plugin/recentcontactsmodel.cpp
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/rootmodel.cpp
  applets/kicker/plugin/runnermatchesmodel.cpp

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-04 Thread Méven Car 
meven updated this revision to Diff 72754.
meven added a comment.


  Clean unwanted change

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26386?vs=72752=72754

BRANCH
  arcpatch-D26386_1

REVISION DETAIL
  https://phabricator.kde.org/D26386

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/kicker/plugin/actionlist.h
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/appsmodel.cpp
  applets/kicker/plugin/contactentry.cpp
  applets/kicker/plugin/recentcontactsmodel.cpp
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/rootmodel.cpp
  applets/kicker/plugin/runnermatchesmodel.cpp

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-04 Thread Méven Car 
meven updated this revision to Diff 72752.
meven added a comment.


  Change signature of Kicker::createActionItem and update all its users

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26386?vs=72697=72752

BRANCH
  arcpatch-D26386_1

REVISION DETAIL
  https://phabricator.kde.org/D26386

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/kicker/plugin/actionlist.h
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/appsmodel.cpp
  applets/kicker/plugin/contactentry.cpp
  applets/kicker/plugin/recentcontactsmodel.cpp
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/rootmodel.cpp
  applets/kicker/plugin/runnermatchesmodel.cpp

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-03 Thread Méven Car 
meven added a comment.


  In D26386#587169 , @hein wrote:
  
  > It should be `iconName` after `label`.
  
  
  I like this suggestion.
  It entails a lot of error-prone code change.
  Will do.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-03 Thread Eike Hein 
hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.


  It should be `iconName` after `label`.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham, hein
Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-03 Thread Nathaniel Graham 
ngraham added a comment.


  Yeah, it definitely bloats this diff, but maybe it would make subsequent ones 
smaller and cleaner?
  
  #plasma  folks, what do you think?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-03 Thread Méven Car 
meven added a comment.


  I am not too fond of this version growing the number of parameters of 
Kicker::createActionItem, and given its third parameter before icon is QVariant 
this becomes error-prone.
  There are a lot more usage of this method that I haven't yet updated, if we 
want to follow this course.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-03 Thread Méven Car 
meven updated this revision to Diff 72697.
meven added a comment.


  Add an icon parameter to Kicker::createActionItem

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26386?vs=72673=72697

BRANCH
  arcpatch-D26386

REVISION DETAIL
  https://phabricator.kde.org/D26386

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/kicker/plugin/actionlist.h
  applets/kicker/plugin/recentusagemodel.cpp

To: meven, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-03 Thread Méven Car 
meven added a comment.


  In D26386#587025 , @ngraham wrote:
  
  > Is there no way to set the icon during initialization so these can stay 
const?
  
  
  I would have needed to edit `Kicker::createActionItem`, it might be 
interesting.
  But not keeping the const is not too important those variables have a limited 
lifetime anyway.
  Not having const here does not add a copy or anything.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-03 Thread Nathaniel Graham 
ngraham added a comment.


  Is there no way to set the icon during initialization so these can stay const?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26386

To: meven, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26386: Kicker/RecentDocuments: add icons to actions

2020-01-03 Thread Méven Car 
meven created this revision.
meven added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26386

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp

To: meven, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart