D26388: Get rid of KGlobalSettings
This revision was automatically updated to reflect the committed changes. Closed by commit R119:29c01adcc4a5: Get rid of KGlobalSettings (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26388?vs=72676=73049 REVISION DETAIL https://phabricator.kde.org/D26388 AFFECTED FILES kcms/desktoppaths/CMakeLists.txt kcms/desktoppaths/globalpaths.cpp To: ervin, #plasma, mart, davidedmundson, bport, crossi, meven Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26388: Get rid of KGlobalSettings
davidedmundson accepted this revision. davidedmundson added a comment. Couldn't even find a reference in kde-workspace / kdelibs in plasma4 code when I went searching... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26388 To: ervin, #plasma, mart, davidedmundson, bport, crossi, meven Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26388: Get rid of KGlobalSettings
meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Looks fine to me REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26388 To: ervin, #plasma, mart, davidedmundson, bport, crossi, meven Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26388: Get rid of KGlobalSettings
ervin created this revision. ervin added reviewers: Plasma, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY After grepping in all our repositories, it looks like the SETTINGS_PATHS category is completely unused (at least I couldn't find anyone doing anything paths related on the slot end). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26388 AFFECTED FILES kcms/desktoppaths/CMakeLists.txt kcms/desktoppaths/globalpaths.cpp To: ervin, #plasma, mart, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
