D26574: [Applet]Hide hamburger menu when empty

2020-01-31 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:10ab204a62cf: [Applet]Hide hamburger menu when empty 
(authored by gvgeo, committed by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26574?vs=74150=74801

REVISION DETAIL
  https://phabricator.kde.org/D26574

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml

To: gvgeo, #vdg, #plasma, drosca, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26574: [Applet]Hide hamburger menu when empty

2020-01-22 Thread George Vogiatzis 
gvgeo updated this revision to Diff 74150.
gvgeo added a comment.


  rebase

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26574?vs=73922=74150

BRANCH
  menu3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26574

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml

To: gvgeo, #vdg, #plasma, drosca, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26574: [Applet]Hide hamburger menu when empty

2020-01-20 Thread George Vogiatzis 
gvgeo updated this revision to Diff 73922.
gvgeo added a comment.


  Rebase

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26574?vs=73241=73922

BRANCH
  menu3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26574

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml

To: gvgeo, #vdg, #plasma, drosca, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26574: [Applet]Hide hamburger menu when empty

2020-01-10 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  ports (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26574

To: gvgeo, #vdg, #plasma, drosca, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26574: [Applet]Hide hamburger menu when empty

2020-01-10 Thread George Vogiatzis 
gvgeo added a comment.


  KCM is in a state of confusion. Doesn't see the port change from lock 
prevention, and shows the port that was selected(unavailable). While the volume 
and mute affect the active port.
  If these patches ever get accepted, can see at a later time this part.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26574

To: gvgeo, #vdg, #plasma, drosca
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26574: [Applet]Hide hamburger menu when empty

2020-01-10 Thread George Vogiatzis 
gvgeo created this revision.
gvgeo added reviewers: VDG, Plasma, drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Don't show devices/applications hamburger menu when there are no options.
  Hide "Record/Play all audio via this device" if there is only 1 device.
  Prevent unavailable ports be active.
  
  Last is a workaround to prevent locking a device to an unavailable port.
  This can happen cause of the lack of a call from pulseaudio for a port
  availability change.

TEST PLAN
  Lock can happen when an unused and available port becomes unavailable.
  Until data refresh, a user can select the unavailable port. After the
  switch if there is only 1 available port, UI will hide port selection,
  locking user to an unavailable port.
  
  Depends on D26418 

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  ports (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26574

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml

To: gvgeo, #vdg, #plasma, drosca
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart