D26580: Kicker/RecentDocuments display place's icon when resource matches one

2020-01-21 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b51fb9dc522b: Kicker/RecentDocuments display places 
icon when resource matches one (authored by meven).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26580?vs=73268=74070

REVISION DETAIL
  https://phabricator.kde.org/D26580

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/recentusagemodel.h

To: meven, #plasma, ngraham, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26580: Kicker/RecentDocuments display place's icon when resource matches one

2020-01-21 Thread Nathaniel Graham 
ngraham added a comment.


  Yes please.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26580

To: meven, #plasma, ngraham, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26580: Kicker/RecentDocuments display place's icon when resource matches one

2020-01-21 Thread Méven Car 
meven added a comment.


  In D26580#598081 , @hein wrote:
  
  > This patch is fine and in line with the existing implementation, but it 
occurs to me we probably should make the RecentUsageModel use FileEntry and put 
it centrally there at some point.
  
  
  Good idea
  
  Should I push to 5.18 branch ?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26580

To: meven, #plasma, ngraham, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26580: Kicker/RecentDocuments display place's icon when resource matches one

2020-01-21 Thread Eike Hein 
hein added a comment.


  This patch is fine and in line with the existing implementation, but it 
occurs to me we probably should make the RecentUsageModel use FileEntry and put 
it centrally there at some point.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26580

To: meven, #plasma, ngraham, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26580: Kicker/RecentDocuments display place's icon when resource matches one

2020-01-21 Thread Méven Car 
meven added a comment.


  I am thinking about merging this and push to 5.18 branch, this ought to be in 
5.18.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26580

To: meven, #plasma, ngraham, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26580: Kicker/RecentDocuments display place's icon when resource matches one

2020-01-18 Thread Méven Car 
meven added a comment.


  ping @hein 
  Might be good to go to plasma 5.18

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26580

To: meven, #plasma, ngraham, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26580: Kicker/RecentDocuments display place's icon when resource matches one

2020-01-16 Thread Méven Car 
meven added a comment.


  ping @hein

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26580

To: meven, #plasma, ngraham, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26580: Kicker/RecentDocuments display place's icon when resource matches one

2020-01-11 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Very nice, a big improvement visually. Make sure @hein or another #plasma 
 person is good with this too.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26580

To: meven, #plasma, ngraham, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26580: Kicker/RecentDocuments display place's icon when resource matches one

2020-01-11 Thread Méven Car 
meven updated this revision to Diff 73268.
meven added a comment.


  Undo unintended change

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26580?vs=73267=73268

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26580

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/recentusagemodel.h

To: meven, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26580: Kicker/RecentDocuments display place's icon when resource matches one

2020-01-11 Thread Méven Car 
meven updated this revision to Diff 73267.
meven added a comment.


  RecentUsageModel Allow to open smb:/ sftp:/ resources

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26580?vs=73262=73267

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26580

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/recentusagemodel.h

To: meven, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26580: Kicker/RecentDocuments display place's icon when resource matches one

2020-01-11 Thread Méven Car 
meven created this revision.
meven added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26580

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp
  applets/kicker/plugin/recentusagemodel.h

To: meven, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart