D26609: [kstyle] Port to KWindowSystem shadows API
This revision was automatically updated to reflect the committed changes. zzag marked an inline comment as done. Closed by commit R113:164dbdb334b8: [kstyle] Port to KWindowSystem shadows API (authored by zzag). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26609?vs=73644&id=74066#toc REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26609?vs=73644&id=74066 REVISION DETAIL https://phabricator.kde.org/D26609 AFFECTED FILES kstyle/oxygenshadowhelper.cpp kstyle/oxygenshadowhelper.h To: zzag, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26609: [kstyle] Port to KWindowSystem shadows API
zzag marked an inline comment as done. zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in oxygenshadowhelper.cpp:291 > I don't understand what this line is trying to do I presume that it acted as a sub-surface test, in either case we don't need it. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D26609 To: zzag, #kwin, #plasma Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26609: [kstyle] Port to KWindowSystem shadows API
zzag updated this revision to Diff 73644. zzag added a comment. - Drop sub-surface check - Don't use obsolete QWidget::isTopLevel() REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26609?vs=73351&id=73644 REVISION DETAIL https://phabricator.kde.org/D26609 AFFECTED FILES kstyle/oxygenshadowhelper.cpp kstyle/oxygenshadowhelper.h To: zzag, #kwin, #plasma Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26609: [kstyle] Port to KWindowSystem shadows API
davidedmundson added inline comments. INLINE COMMENTS > oxygenshadowhelper.cpp:291 > #if OXYGEN_HAVE_KWAYLAND > -if( widget->windowHandle()->parent() ) return false; > -if( !_shadowManager || !_shmPool ) return false; > - > -const bool isDockWidget( this->isDockWidget( widget ) || > this->isToolBar( widget ) ); > -const TileSet &tiles = isDockWidget ? _dockTiles : _tiles; > - > -if( !tiles.isValid() ) return false; > - > -// create shadow > -using namespace KWayland::Client; > -auto s = Surface::fromWindow( widget->windowHandle() ); > -if( !s ) return false; > - > -auto shadow = _shadowManager->createShadow( s, widget ); > -if( !shadow->isValid() ) return false; > - > -// add the shadow elements > -shadow->attachTop( _shmPool->createBuffer( tiles.pixmap( 1 > ).toImage() ) ); > -shadow->attachTopRight( _shmPool->createBuffer( tiles.pixmap( 2 > ).toImage() ) ); > -shadow->attachRight( _shmPool->createBuffer( tiles.pixmap( 5 > ).toImage() ) ); > -shadow->attachBottomRight( _shmPool->createBuffer( tiles.pixmap( 8 > ).toImage() ) ); > -shadow->attachBottom( _shmPool->createBuffer( tiles.pixmap( 7 > ).toImage() ) ); > -shadow->attachBottomLeft( _shmPool->createBuffer( tiles.pixmap( 6 > ).toImage() ) ); > -shadow->attachLeft( _shmPool->createBuffer( tiles.pixmap( 3 > ).toImage() ) ); > -shadow->attachTopLeft( _shmPool->createBuffer( tiles.pixmap( 0 > ).toImage() ) ); > - > -shadow->setOffsets( shadowMargins( widget ) ); > -shadow->commit(); > -s->commit( Surface::CommitFlag::None ); > - > -return true; > -#else > -Q_UNUSED( widget ); > +if( widget->windowHandle()->parent() ) return; > #endif I don't understand what this line is trying to do REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D26609 To: zzag, #kwin, #plasma Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26609: [kstyle] Port to KWindowSystem shadows API
zzag created this revision. zzag added reviewers: KWin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REPOSITORY R113 Oxygen Theme BRANCH port-to-shadows-api REVISION DETAIL https://phabricator.kde.org/D26609 AFFECTED FILES kstyle/oxygenshadowhelper.cpp kstyle/oxygenshadowhelper.h To: zzag, #kwin, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
