D26686: Remove scrollbar related workarounds from list delegates
This revision was automatically updated to reflect the committed changes. Closed by commit R858:9dfb38179ac5: Remove scrollbar related workarounds from list delegates (authored by ahiemstra). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26686?vs=73606&id=74442 REVISION DETAIL https://phabricator.kde.org/D26686 AFFECTED FILES org.kde.desktop/CheckDelegate.qml org.kde.desktop/ItemDelegate.qml org.kde.desktop/RadioDelegate.qml org.kde.desktop/SwitchDelegate.qml To: ahiemstra, #plasma, ngraham, mart Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26686: Remove scrollbar related workarounds from list delegates
ahiemstra added a comment. That logic is in ScrollView already. Since the delegate no longer needs special padding, this changes the padding to the same value for left or right. We could change the padding depending on where the scrollbar is, but I don't think that would be an improvement. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D26686 To: ahiemstra, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26686: Remove scrollbar related workarounds from list delegates
ngraham added a comment. Will we still need the `LayoutMirroring.enabled ?` logic to account for when using an RTL language where the scrollbar is on the left side? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D26686 To: ahiemstra, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26686: Remove scrollbar related workarounds from list delegates
ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Now that we no longer overlap scrollbars, we can get rid of all the workarounds needed to make the overlapping scrollbars work. This gets rid of the workarounds in ItemDelegate and related items. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH scrollbar_workarounds REVISION DETAIL https://phabricator.kde.org/D26686 AFFECTED FILES org.kde.desktop/CheckDelegate.qml org.kde.desktop/ItemDelegate.qml org.kde.desktop/RadioDelegate.qml org.kde.desktop/SwitchDelegate.qml To: ahiemstra, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
