D26688: WIP: [Night Color] Display time when the next transition will start
zzag updated this revision to Diff 78291. zzag added a comment. Rebase on master. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26688?vs=73686=78291 BRANCH show-next-transition-timings REVISION DETAIL https://phabricator.kde.org/D26688 AFFECTED FILES applets/nightcolor/package/contents/ui/main.qml applets/nightcolor/plugin/monitor.cpp applets/nightcolor/plugin/monitor.h applets/nightcolor/plugin/monitor_p.h To: zzag, #plasma, #vdg, ngraham Cc: ngraham, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26688: WIP: [Night Color] Display time when the next transition will start
ngraham added a comment. Here's my suggestions for what to display in the applet for various conditions: Feature disabled: no tray icon shown anywhere Feature enabled but not active: tray icon in passive state (only in pop-up) with the following text: > Night color is inactive > Activation will begin at Feature enabled, transition to turning on is in progress: tray icon is in active state with the following text: > Night color is activating > Colors fully changed at Feature enabled and colors are fully changed: tray icon is in active state with the following text: > Night color is active with color temperature > Deactivation will begin at tomorrow Feature enabled, transition to turning off is in progress: tray icon is in active state with the following text: > Night color is deactivating > Colors will return to normal at REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D26688 To: zzag, #plasma, #vdg Cc: ngraham, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26688: WIP: [Night Color] Display time when the next transition will start
zzag updated this revision to Diff 73686. zzag added a comment. - Use i18nc(). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26688?vs=73685=73686 BRANCH show-next-transition-timings REVISION DETAIL https://phabricator.kde.org/D26688 AFFECTED FILES applets/nightcolor/package/contents/ui/main.qml applets/nightcolor/plugin/monitor.cpp applets/nightcolor/plugin/monitor.h applets/nightcolor/plugin/monitor_p.h To: zzag, #plasma, #vdg Cc: ngraham, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26688: WIP: [Night Color] Display time when the next transition will start
zzag updated this revision to Diff 73685. zzag added a comment. - Add Monitor.NeutralTemperature constant - Display locale time - Nate's suggestion REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26688?vs=73616=73685 BRANCH show-next-transition-timings REVISION DETAIL https://phabricator.kde.org/D26688 AFFECTED FILES applets/nightcolor/package/contents/ui/main.qml applets/nightcolor/plugin/monitor.cpp applets/nightcolor/plugin/monitor.h applets/nightcolor/plugin/monitor_p.h To: zzag, #plasma, #vdg Cc: ngraham, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26688: WIP: [Night Color] Display time when the next transition will start
anthonyfieroni added inline comments. INLINE COMMENTS > zzag wrote in main.qml:57 > 6500K is the neutral screen color temperature. Although I don't think that I > follow you. Do you recommend not to hardcode this constant? > Do you recommend not to hardcode this constant? Yes. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D26688 To: zzag, #plasma, #vdg Cc: ngraham, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26688: WIP: [Night Color] Display time when the next transition will start
zzag added inline comments. INLINE COMMENTS > anthonyfieroni wrote in main.qml:57 > The bigger todo is hardcoded 6500K ? 6500K is the neutral screen color temperature. Although I don't think that I follow you. Do you recommend not to hardcode this constant? > ngraham wrote in main.qml:59 > This is a comma splice. Change to: > > Night Color is not active. The next transition... > > or > > Night Color is not active; the next transition... > > or > > Night Color is not active, but the next transition... Thank you very much for suggesting correct messages. As a VDG person, do you have tips how to better inform the user that Night Color currently doesn't have any effect and it will activate a bit later? Given tight time budget, I don't target 5.18 so no rush. Although it would be great to get this little feature in the next release. Also, what time format should we use? The current one is way too informative if you ask me. I'm pretty happy about the backend side, but the frontend obviously still needs some work... :( REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D26688 To: zzag, #plasma, #vdg Cc: ngraham, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26688: WIP: [Night Color] Display time when the next transition will start
ngraham added inline comments.
INLINE COMMENTS
> main.qml:59
> +// TODO: Show a better message...
> +return i18n("Night Color is not active, the next transition
> will occur at %1",
> +
> monitor.scheduledTransitionDateTime.toLocaleString(Qt.locale()));
This is a comma splice. Change to:
Night Color is not active. The next transition...
or
Night Color is not active; the next transition...
or
Night Color is not active, but the next transition...
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D26688
To: zzag, #plasma, #vdg
Cc: ngraham, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev,
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26688: WIP: [Night Color] Display time when the next transition will start
anthonyfieroni added inline comments.
INLINE COMMENTS
> main.qml:57
> +if (monitor.operationMode != Monitor.ConstantMode) {
> +if (monitor.currentTemperature == 6500) {
> +// TODO: Show a better message...
The bigger todo is hardcoded 6500K ?
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D26688
To: zzag, #plasma, #vdg
Cc: anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26688: WIP: [Night Color] Display time when the next transition will start
zzag created this revision. zzag added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY Currently the applet displays "Night Color is active (%screen color temperature% K)" all the time even if the screen is not actually red-ish. It may be really confusing for ordinary people and I expect that a few bug reports saying "the applet shows that Night Color is active, but in reality it isn't" might be reported. The best thing would be to display "Night Color is not active, the next transition will start at %datetime% and end at %datetime%" or something along the line. This patch is still WIP because I'm not 100% sure how to present this kind of information to user. REPOSITORY R114 Plasma Addons BRANCH show-next-transition-timings REVISION DETAIL https://phabricator.kde.org/D26688 AFFECTED FILES applets/nightcolor/package/contents/ui/main.qml applets/nightcolor/plugin/monitor.cpp applets/nightcolor/plugin/monitor.h applets/nightcolor/plugin/monitor_p.h To: zzag, #plasma, #vdg Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
