D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[Nathaniel Graham]

ngraham updated this revision to Diff 80593.
ngraham added a comment.


  Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26695?vs=74052=80593

BRANCH
  standardshortcuts-minimum-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26695

AFFECTED FILES
  kcms/standard_actions/standard_actions_module.cpp

To: ngraham, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[Nathaniel Graham]

ngraham updated this revision to Diff 80595.
ngraham added a comment.


  700 -> 600 to accommodate people who still have netbooks or run Plasma in a 
VM with a
  tiny window because guest tools aren't installed

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26695?vs=80593=80595

BRANCH
  standardshortcuts-minimum-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26695

AFFECTED FILES
  kcms/standard_actions/standard_actions_module.cpp

To: ngraham, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8e0f525a9633: [KCMs/Standard Actions] Give KCMShell 
window a sane default size (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26695?vs=80595=80596

REVISION DETAIL
  https://phabricator.kde.org/D26695

AFFECTED FILES
  kcms/standard_actions/standard_actions_module.cpp

To: ngraham, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[Nathaniel Graham]

ngraham added a comment.


  Ping!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26695

To: ngraham, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26695

To: ngraham, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[Nathaniel Graham]

ngraham updated this revision to Diff 74052.
ngraham marked an inline comment as done.
ngraham added a comment.


  Use `setMinimumSize()`

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26695?vs=73657=74052

BRANCH
  standardshortcuts-minimum-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26695

AFFECTED FILES
  kcms/standard_actions/standard_actions_module.cpp

To: ngraham, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> standard_actions_module.cpp:73
> +m_editor->setMinimumWidth(700);
> +m_editor->setMinimumHeight(600);
> +

`setMinimumSize()`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26695

To: ngraham, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[Christoph Feck]

cfeck added a comment.


  Note that a window's minimum size does not include decorations or the panel. 
I suggest to subtract 60 pixels from the minimum height, otherwise on a 800x600 
screen the buttons are likely hidden behind the panel.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26695

To: ngraham, #plasma
Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[Nathaniel Graham]

ngraham added a comment.


  The goal is to have a sane default size.
  
  This patch in its current state seems to do that, since setting a minimum 
width and height on `m_editor` doesn't actually prevent it from being resized 
to be smaller due to its sizePolicy.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26695

To: ngraham, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[David Edmundson]

davidedmundson added a comment.


  > Is there a better way?
  
  Depends what the goal is. To set a minimum size or to change the default size.
  
  Commit title says one thing, comment says another.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26695

To: ngraham, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[Nathaniel Graham]

ngraham added a comment.


  I don't know of any netbooks shorter with screens shorter than 600px, which 
is why I chose 600. Also, the window is resizable to be smaller.
  
  Is there a better way?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26695

To: ngraham, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[David Edmundson]

davidedmundson added a comment.


  Ok, but why minimum? 
  We still have a few reports of people on weird tiny netbooks.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26695

To: ngraham, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 377653
  FIXED-IN: 5.18.0

TEST PLAN
  Before: F7884930: Before.png 
  After: F7884929: After.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  standardshortcuts-minimum-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26695

AFFECTED FILES
  kcms/standard_actions/standard_actions_module.cpp

To: ngraham, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart