D26698: [widgetexplorer] Fix animate in animation

2020-01-17 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:977665254990: [widgetexplorer] Fix animate in animation 
(authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26698?vs=73661=73769

REVISION DETAIL
  https://phabricator.kde.org/D26698

AFFECTED FILES
  desktoppackage/contents/explorer/WidgetExplorer.qml

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26698: [widgetexplorer] Fix animate in animation

2020-01-15 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oh never mind, I see it now. Quite subtle! Nice fix.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26698

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26698: [widgetexplorer] Fix animate in animation

2020-01-15 Thread Nathaniel Graham 
ngraham added a comment.


  Hmm, I don't notice a difference before and after this patch. Maybe I'm not 
noticing the original problem

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26698

To: davidedmundson, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26698: [widgetexplorer] Fix animate in animation

2020-01-15 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The animation in comes in from offscreen on the left.
  
  "to: 0" was correct when we had one column. With the 2 column view it
  means we animate two items on top of each other and jump when the
  animation completes. We want to animate to the final position the item
  will end up in.
  
  It bugs me more than it probably should.

TEST PLAN
  Search for "asdfasdfsadfsadf"
  Remove search
  Animation now looks ok, instead of horrific

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26698

AFFECTED FILES
  desktoppackage/contents/explorer/WidgetExplorer.qml

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart