D26718: aggregate text for KRunner in DesktopView

[Méven Car]

meven closed this revision.
meven added a comment.


  At moved to 
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/148

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26718

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik
Cc: meven, pzro, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26718: aggregate text for KRunner in DesktopView

[Piotr Dabrowski]

pdabrowski added a comment.


  Moved to GitLab: 
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/148

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26718

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik
Cc: pzro, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26718: aggregate text for KRunner in DesktopView

[H. M.]

pzro added a comment.


  Hey guys, this is what I think
  
  1. Having the shell capture input and forward it to KRunner when it comes up 
- because KRunner is too slow to come up and capture text on demand
  2. Having KRunner in the background from the beginning - because KRunner is 
too slow on demand
  
  I say solution 1 is hackier than 2 and 1 doesn't even solve all the problems 
(like when invoking with alt+space). Yes, then there will more memory usage 
from the start (I see about 36M just checking in KSysGuard) but a worthwhile 
trade off for a better experience. KRunner is one of the best things in KDE.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26718

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik
Cc: pzro, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26718: aggregate text for KRunner in DesktopView

[Nathaniel Graham]

ngraham added a comment.


  @davidedmundson stable branch?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26718

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26718: aggregate text for KRunner in DesktopView

[Nathaniel Graham]

ngraham added a comment.


  All right then. I guess it is a tricky problem.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26718

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26718: aggregate text for KRunner in DesktopView

[Piotr Dabrowski]

pdabrowski added a comment.


  In D26718#622311 , @ngraham wrote:
  
  > Are you planning to work on that other part in this patch, or in a separate 
one?
  
  
  I do not plan to change this patch.
  As for solving the issue with KRunner invoked from shortcut, I still do not 
have a good solution for it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26718

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26718: aggregate text for KRunner in DesktopView

[Nathaniel Graham]

ngraham added a comment.


  In D26718#622618 , @davidedmundson 
wrote:
  
  > > Are you planning to work on that other part in this patch, or in a 
separate one?
  >
  > To do what exactly?
  
  
  Find another way to fix the problem of keystrokes getting eaten when 
activating KRunner using a global shortcut.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26718

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26718: aggregate text for KRunner in DesktopView

[David Edmundson]

davidedmundson added a comment.


  > Are you planning to work on that other part in this patch, or in a separate 
one?
  
  To do what exactly?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26718

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26718: aggregate text for KRunner in DesktopView

[Nathaniel Graham]

ngraham added a comment.


  Can confirm the fix when running from the desktop, but not when using the 
shortcut. So I wouldn't call 416145 fully fixed yet. Are you planning to work 
on that other part in this patch, or in a separate one?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26718

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26718: aggregate text for KRunner in DesktopView

[Piotr Dabrowski]

pdabrowski updated this revision to Diff 76799.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26718?vs=76798=76799

REVISION DETAIL
  https://phabricator.kde.org/D26718

AFFECTED FILES
  shell/desktopview.cpp
  shell/desktopview.h

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26718: aggregate text for KRunner in DesktopView

[Piotr Dabrowski]

pdabrowski added inline comments.

INLINE COMMENTS

> desktopview.cpp:246
>  
> +bool DesktopView::handleKRunnerTextInput(QKeyEvent *e) {
> +// allow only Shift and GroupSwitch modifiers

TODO: code style: {

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26718

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26718: aggregate text for KRunner in DesktopView

[Piotr Dabrowski]

pdabrowski updated this revision to Diff 76798.
pdabrowski retitled this revision from "autostart KRunner with Plasma, 
aggregate text for KRunner in DesktopView" to "aggregate text for KRunner in 
DesktopView".
pdabrowski edited the summary of this revision.
pdabrowski added a comment.


  Dropped autostart feature leaving only text aggregation in DesktopView.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26718?vs=73740=76798

REVISION DETAIL
  https://phabricator.kde.org/D26718

AFFECTED FILES
  shell/desktopview.cpp
  shell/desktopview.h

To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart